← Back to issue list

ci: add path filter to qa workflow, make jobs conditional

View original Github issue

Metadata

Project
debcraft
Number
#160
Type
pull request
State
merged
Author
medubelko
Labels
—
Created
Updated
Closed

Current evaluation

Merged in fa39c6f, adding QA path filtering and making Starflow lint/test jobs conditional so docs-only changes can skip them (CRAFT-5161).

Resolution: closed resolved

Reason: PR #160 was approved and merged into main as commit fa39c6f. The maintainer also confirmed successful docs-only filtering in workflow run 26479290215.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add the filter to the workflow directly, and pass it on to the Starflow lint and test workflows. Depends on https://github.com/canonical/starflow/pull/143. The lint workflow has already been changed upstream. For CRAFT-5161. --- - [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`?

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged in fa39c6f, adding QA path filtering and making Starflow lint/test jobs conditional so docs-only changes can skip them (CRAFT-5161).
stealth/space-bunny-alpha — closed resolved Merged PR #160 in commit fa39c6f, adding a QA path filter and making lint/test jobs conditional, with filters passed to Starflow workflows for CRAFT-5161.
qwen/qwen3.6-35b-a3b — — Merged: added a path filter to the QA workflow to conditionally run lint and test jobs. Approved, passed CI, and verified to skip for docs-only changes. Resolves CRAFT-5161.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/starflow#143 (confidence 95%)

    Upstream Starflow change required for lint and test workflows to accept and honor the source-files filter.

Related issues

Issue Project State Summary Similarity
#1212 ci: add path filter to qa workflow, make jobs conditional rockcraft merged PR #1212 merged: added path filters to rockcraft's QA workflow, made lint/test jobs conditional and passed filters on to the Starflow lint/test workflows (CRAFT-5161). Author verified jobs skip on docs-only changes.
92%
#6256 ci: add path filter to qa workflow, make jobs conditional snapcraft merged PR #6256 (CRAFT-5161) merged as commit 9a7074ce8, adding dorny/paths-filter to .github/workflows/qa.yaml, gating lint/test jobs on a paths filter and forwarding filters to Starflow workflows.
92%
#2701 ci: filter in qa workflow charmcraft merged Merged charmcraft#2701, adding path filters to the QA workflow and forwarding them to the called lint workflow for CRAFT-5161.
83%
#546 docs: add filter to qa workflow starbase merged Merged PR (commit ccb17d2): adds a dorny/paths-filter "filter" job to .github/workflows/qa.yaml so lint/test reusable workflows only run for source files, skipping docs-only PRs.
78%
#1371 ci: add explicit permissions on QA workflow rockcraft closed Merged explicit read permissions for actions, contents, and pull requests into the QA workflow in commit 559eb218, enabling Starflow path-filter jobs.
77%
#2710 ci: fix qa workflow conditional charmcraft merged Merged PR #2710 as commit 2171f609, correcting a typo in the QA workflow path-filter conditional that had prevented the workflow from running.
76%
#2885 ci: Fix QA reusable workflow permissions for Starflow lint charmcraft closed Closed unmerged as redundant after canonical/starbase#557 merged cd8d4873, adding read-only QA permissions upstream and restoring reusable Starflow lint execution.
74%
#60 ci: use starflow policy and QA workflows craft-platforms merged Merged into main as commit ab5f54e, replacing project-specific CI configuration with Canonical Starflow policy and QA workflows across eight files.
73%
#2688 ci: make workflows conditional on affected files charmcraft merged PR #2688 merged as commit a32937a6: added paths-ignore conditions so QA/Test, Check policy, Experimental, Tests and Spread workflows only run on affected files; Split Spread into 'Spread tests for source' and docs.
72%
#1731 ci: fix permissions for QA workflow craft-parts closed Closed unmerged after approval: #1731 proposed explicit read permissions for incoming Starflow QA jobs, but no resolving commit landed and remaining CI checks never completed.
71%