← Back to issue list

ci: add path filter to qa workflow, make jobs conditional

View original Github issue

Metadata

Project
rockcraft
Number
#1212
Type
pull request
State
merged
Author
medubelko
Labels
—
Created
Updated
Closed

Current evaluation

PR #1212 merged: added path filters to rockcraft's QA workflow, made lint/test jobs conditional and passed filters on to the Starflow lint/test workflows (CRAFT-5161). Author verified jobs skip on docs-only changes.

Resolution: closed resolved

Reason: The pull request itself was merged with 2 approvals, implementing the QA path filters and conditional lint/test jobs; the author commented with a fork Actions run showing test jobs skipping for a docs-only change, confirming the filter works as intended.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add the filter to the workflow directly, and pass it on to the Starflow lint and test workflows. Depends on https://github.com/canonical/starflow/pull/143. The lint workflow has already been changed upstream. For CRAFT-5161. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/rockcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #1212 merged: added path filters to rockcraft's QA workflow, made lint/test jobs conditional and passed filters on to the Starflow lint/test workflows (CRAFT-5161). Author verified jobs skip on docs-only changes.
stealth/space-bunny-alpha — closed resolved Merged canonical/rockcraft#1212, adding QA path filters and conditional lint/test jobs for CRAFT-5161. Verified that test jobs skip for a docs-only change.
qwen/qwen3.6-35b-a3b — — Merged. Implemented a path filter in the QA workflow to conditionally execute lint and test jobs based on modified files. Verified to skip execution for unrelated changes. Relies on upstream Starflow workflow updates.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Implements path filtering in the QA workflow to conditionally execute lint and test jobs based on changed files. Author verified jobs correctly skip for documentation-only updates, optimizing CI for CRAFT-5161.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/starflow#143 (confidence 80%)

    Upstream Starflow PR this change depends on for the lint workflow filter support

  • Related To: canonical/snapcraft#6256 (confidence 75%)

    Identical CRAFT-5161 change applied to snapcraft's QA workflow

  • Related To: canonical/debcraft#160 (confidence 75%)

    Identical CRAFT-5161 change applied to debcraft's QA workflow (merged in fa39c6f)

Related issues

Issue Project State Summary Similarity
#160 ci: add path filter to qa workflow, make jobs conditional debcraft merged Merged in fa39c6f, adding QA path filtering and making Starflow lint/test jobs conditional so docs-only changes can skip them (CRAFT-5161).
92%
#6256 ci: add path filter to qa workflow, make jobs conditional snapcraft merged PR #6256 (CRAFT-5161) merged as commit 9a7074ce8, adding dorny/paths-filter to .github/workflows/qa.yaml, gating lint/test jobs on a paths filter and forwarding filters to Starflow workflows.
88%
#2701 ci: filter in qa workflow charmcraft merged Merged charmcraft#2701, adding path filters to the QA workflow and forwarding them to the called lint workflow for CRAFT-5161.
83%
#546 docs: add filter to qa workflow starbase merged Merged PR (commit ccb17d2): adds a dorny/paths-filter "filter" job to .github/workflows/qa.yaml so lint/test reusable workflows only run for source files, skipping docs-only PRs.
77%
#1375 ci: Add missing permissions to QA lint workflow rockcraft closed PR #1375 (rockcraft) adding job-level contents/pull-requests read permissions to the QA lint workflow was closed unmerged by @lengau as redundant — the workflow's existing workflow-level permissions were already sufficient.
76%
#1371 ci: add explicit permissions on QA workflow rockcraft closed Merged explicit read permissions for actions, contents, and pull requests into the QA workflow in commit 559eb218, enabling Starflow path-filter jobs.
72%
#2710 ci: fix qa workflow conditional charmcraft merged Merged PR #2710 as commit 2171f609, correcting a typo in the QA workflow path-filter conditional that had prevented the workflow from running.
72%
#1218 ci: add checkout step to qa workflow filter rockcraft merged Merged PR #1218 by medubelko (+4 lines) added an actions/checkout step before dorny/paths-filter in the QA workflow, fixing filter failures on push events; approved with 1 reviewer.
70%