ci: fix qa workflow conditional
Metadata
Current evaluation
Merged PR #2710 as commit 2171f609, correcting a typo in the QA workflow path-filter conditional that had prevented the workflow from running.
Resolution: closed resolved
Reason: PR #2710 merged into main as commit 2171f609 after approval, fixing the QA workflow conditional. Complete workflow restoration remained dependent on canonical/starflow#146.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Correct a typo that locked up the workflow.
Won't completely fix the workflows until https://github.com/canonical/starflow/pull/146 is merged.
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/charmcraft/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [ ] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [ ] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2710 as commit 2171f609, correcting a typo in the QA workflow path-filter conditional that had prevented the workflow from running. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged a CI typo fix to unblock the QA workflow, with broader workflow conditional changes tracked in canonical/starflow#146. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a fix correcting a typo in the CI QA workflow conditional that was locking the pipeline. Approved by two reviewers and passed CI checks. Restores workflow execution, with full resolution pending upstream starflow PR #146. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for a typo in the CI QA workflow conditional that was causing failures. The change resolves the immediate lockup, though full workflow stability depends on canonical/starflow#146. Linkcheck issues were bypassed. |
Update history
No update history recorded yet.
Related work
-
Blocked By:
canonical/starflow#146
(confidence 100%)
The PR states that a complete workflow fix awaited this Starflow change.
-
Caused By:
canonical/charmcraft#2701
(confidence 95%)
The preceding QA workflow filter change introduced the conditional corrected here.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #160 ci: add path filter to qa workflow, make jobs conditional | debcraft | merged | Merged in fa39c6f, adding QA path filtering and making Starflow lint/test jobs conditional so docs-only changes can skip them (CRAFT-5161). | |
| #1741 ci: Add missing permissions to QA lint workflow | craft-parts | closed | Closed unmerged after the equivalent QA workflow permission fix landed in commit 585b7237. | |
| #6256 ci: add path filter to qa workflow, make jobs conditional | snapcraft | merged | PR #6256 (CRAFT-5161) merged as commit 9a7074ce8, adding dorny/paths-filter to .github/workflows/qa.yaml, gating lint/test jobs on a paths filter and forwarding filters to Starflow workflows. | |
| #600 ci: Add missing permissions to QA lint workflow | starbase | closed | PR #600 was closed unmerged despite all CI checks passing; no merge commit or recorded replacement was found. | |
| #557 ci: set read permissions for qa workflow | starbase | merged | Merged PR #557 as commit cd8d487, granting the QA workflow read-only contents and pull-request permissions so paths-filter can access GitHub APIs. | |
| #1212 ci: add path filter to qa workflow, make jobs conditional | rockcraft | merged | PR #1212 merged: added path filters to rockcraft's QA workflow, made lint/test jobs conditional and passed filters on to the Starflow lint/test workflows (CRAFT-5161). Author verified jobs skip on docs-only changes. | |
| #2701 ci: filter in qa workflow | charmcraft | merged | Merged charmcraft#2701, adding path filters to the QA workflow and forwarding them to the called lint workflow for CRAFT-5161. | |
| #446 ci: Allow QA reusable workflows to read pull request metadata | imagecraft | closed | The QA permissions fix was approved but closed unmerged after the Conventional Commits policy check failed; no resolving commit or replacement was recorded. | |
| #1731 ci: fix permissions for QA workflow | craft-parts | closed | Closed unmerged after approval: #1731 proposed explicit read permissions for incoming Starflow QA jobs, but no resolving commit landed and remaining CI checks never completed. | |
| #6438 ci: Add missing permissions to QA lint workflow | snapcraft | closed | PR closed unmerged by lengau as redundant: the QA workflow (.github/workflows/qa.yaml) already grants workflow-level contents/pull-requests read permissions on main, so job-level permissions in the lint job were unnecessary. |