← Back to issue list

ci: add path filter to qa workflow, make jobs conditional

View original Github issue

Metadata

Project
snapcraft
Number
#6256
Type
pull request
State
merged
Author
medubelko
Labels
—
Created
Updated
Closed

Current evaluation

PR #6256 (CRAFT-5161) merged as commit 9a7074ce8, adding dorny/paths-filter to .github/workflows/qa.yaml, gating lint/test jobs on a paths filter and forwarding filters to Starflow workflows.

Resolution: closed resolved

Reason: The pull request was merged into main as commit 9a7074ce8 ("ci: add path filter to qa workflow, make jobs conditional"), confirmed in the commit history for .github/workflows/qa.yaml. The author verified in a comment that docs-only changes skip the test jobs as intended.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Add the filter to the workflow directly, and pass it on to the Starflow lint and test workflows. Depends on https://github.com/canonical/starflow/pull/143. The lint workflow has already been changed upstream. For CRAFT-5161. --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [ ] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #6256 (CRAFT-5161) merged as commit 9a7074ce8, adding dorny/paths-filter to .github/workflows/qa.yaml, gating lint/test jobs on a paths filter and forwarding filters to Starflow workflows.
stealth/space-bunny-alpha — closed resolved Merged QA path filtering to make lint and test jobs conditional and pass filters to Starflow workflows for CRAFT-5161; the author verified docs-only changes skip the jobs.
qwen/qwen3.6-35b-a3b — — Merged. Added a path filter to the QA workflow to conditionally run lint and test jobs based on changed files, resolving CRAFT-5161. Depends on upstream Starflow PR #143 and was verified to skip unrelated jobs.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/starflow#143 (confidence 90%)

    PR states it depends on starflow#143 for the lint workflow changes; filters are passed on to Starflow lint/test workflows.

  • Related To: snapcraft#6245 (confidence 70%)

    Adjacent merged PR (commit 40af3e5b5) that made workflows conditional and added docs-only spread tests, overlapping scope with the QA workflow filtering.

Related issues

Issue Project State Summary Similarity
#160 ci: add path filter to qa workflow, make jobs conditional debcraft merged Merged in fa39c6f, adding QA path filtering and making Starflow lint/test jobs conditional so docs-only changes can skip them (CRAFT-5161).
92%
#1212 ci: add path filter to qa workflow, make jobs conditional rockcraft merged PR #1212 merged: added path filters to rockcraft's QA workflow, made lint/test jobs conditional and passed filters on to the Starflow lint/test workflows (CRAFT-5161). Author verified jobs skip on docs-only changes.
88%
#546 docs: add filter to qa workflow starbase merged Merged PR (commit ccb17d2): adds a dorny/paths-filter "filter" job to .github/workflows/qa.yaml so lint/test reusable workflows only run for source files, skipping docs-only PRs.
84%
#2701 ci: filter in qa workflow charmcraft merged Merged charmcraft#2701, adding path filters to the QA workflow and forwarding them to the called lint workflow for CRAFT-5161.
82%
#2710 ci: fix qa workflow conditional charmcraft merged Merged PR #2710 as commit 2171f609, correcting a typo in the QA workflow path-filter conditional that had prevented the workflow from running.
76%
#1218 ci: add checkout step to qa workflow filter rockcraft merged Merged PR #1218 by medubelko (+4 lines) added an actions/checkout step before dorny/paths-filter in the QA workflow, fixing filter failures on push events; approved with 1 reviewer.
75%
#1371 ci: add explicit permissions on QA workflow rockcraft closed Merged explicit read permissions for actions, contents, and pull requests into the QA workflow in commit 559eb218, enabling Starflow path-filter jobs.
75%
#2688 ci: make workflows conditional on affected files charmcraft merged PR #2688 merged as commit a32937a6: added paths-ignore conditions so QA/Test, Check policy, Experimental, Tests and Spread workflows only run on affected files; Split Spread into 'Spread tests for source' and docs.
72%
#194 ci: Set workflow-level read permissions for QA workflow debcraft merged PR #194 merged: added workflow-level read permissions (actions, contents, pull-requests) to .github/workflows/qa.yaml and removed lint job-level overrides, fixing Starflow reusable workflow compilation on PRs.
72%
#428 ci: Set workflow-level read permissions for QA workflow craft-store merged Merged as commit 4aabe63: .github/workflows/qa.yaml now sets workflow-level read permissions (actions, contents, pull-requests) and drops job-local lint overrides, fixing Starflow QA workflow failures on PRs.
71%