many: add reactive charm plugin
Metadata
Current evaluation
PR #610 (charm-tools-based reactive plugin) was closed unmerged on 2021-12-14 by sergiusens in favor of #613, which reimplemented the plugin on the charm tool (CRAFT-699) and merged as 32c8650a.
Resolution: closed superseded
Reason: Maintainer sergiusens closed the PR with the comment 'Closing in favor of #613' rather than merging it. PR #613 (plugins: reactive using charm tool, CRAFT-699) was merged via merge commit 32c8650a on branch charm-tools-plugin and shipped the reactive plugin, which remains in the codebase as charmcraft/parts/plugins/_reactive.py.
Evaluated by: mr-cal-bot
No scores available.
Issue body
The reactive charm plugin uses charm-tools to lint and build a reactive
charm.
Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #610 (charm-tools-based reactive plugin) was closed unmerged on 2021-12-14 by sergiusens in favor of #613, which reimplemented the plugin on the charm tool (CRAFT-699) and merged as 32c8650a. | |
| stealth/space-bunny-alpha | — | closed superseded | PR #610 (reactive charm plugin using charm-tools) was closed unmerged by sergiusens in favour of #613, which reimplemented the reactive plugin on the charm tool and was merged (32c8650a) for CRAFT-699. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged in favor of #613, which reimplemented the reactive charm plugin on top of the charm tool (CRAFT-699) and was merged (commit 32c8650a). | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by merged PR #613, which implemented the reactive charm plugin using the charm tool. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed and superseded by pull request #613. The reactive charm plugin was replaced rather than merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Superseded by pull request #613. The reactive charm plugin addition was closed without merging, as the work was redirected to the referenced PR. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/charmcraft#613
(confidence 99%)
Explicitly named in the closing comment; merged as 32c8650a and implements CRAFT-699 using the charm tool instead of charm-tools.
-
Related To:
canonical/charmcraft#1326
(confidence 35%)
Later fix for the reactive plugin test when the charm tool is installed (4a573702), showing the merged implementation is the one that shipped.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #613 plugins: reactive using charm tool (CRAFT-699) | charmcraft | merged | Merged PR #613 (merge commit 32c8650a, branch charm-tools-plugin) added the reactive charm plugin built on the charm tool, implementing CRAFT-699; 11 files, +499/-8. | |
| #450 parts: add charm plugin (CRAFT-89) | charmcraft | closed | Closed unmerged; CRAFT-89 landed via superseding PR #458, merged as 9dc20872 with implementation commit 437dab55. | |
| #866 reactive_plugin: Fix charm tools version validation | charmcraft | merged | Merged PR #866 as commit 35ec089e (merge c40c30c2), replacing brittle charm-tools version parsing with JSON output and fixing #864. | |
| #804 The reactive plugin is not correctly checking if `charm` failed | charmcraft | closed | Fixed in merged PR #869 (commit 7046f61d), adding negative-return-code handling and return-code logging for both charm invocations. | |
| #864 reactive plugin charm tools version validation code is britle | charmcraft | closed | Fixed by merged PR #866: commit 35ec089e updated reactive-plugin charm-tools validation to use JSON output; merge c40c30c2 closed #864. | |
| #809 Reactive plugin doesn't allow for other `charm` cli arguments. | charmcraft | closed | Resolved by merged PR #863 (merge commit a5f200b1): reactive builds can now pass charm build options such as --layer-index via reactive-charm-build-arguments. | |
| #863 reactive_plugin: Support arguments to charm build command | charmcraft | merged | Merged in charmcraft PR #863 via commit a5f200b1, adding reactive-charm-build-arguments so the reactive plugin can pass options to charm build; fixes #809. | |
| #1326 fix(test): fix reactive plugin test if 'charm' tool is installed | charmcraft | merged | Merged test-only fix making reactive plugin tests deterministic when the charm executable is installed, via PR #1326 and commit 4a573702. | |
| #924 reactive plugin: call `charm build` with `-v` | charmcraft | closed | Fixed by merged PR #2021 (commit 7129d57e): the reactive plugin adds --verbose to charm build unless an explicit verbosity or log level is supplied. | |
| #872 charm artifacts from reactive plugin are missing valuable build metadata | charmcraft | open | Reactive charm artifacts omit .build.manifest and charmtool-version; an exact fix is proposed in open PR charmcraft#2502 and remains under review. |