style: fix ruff issues with ruff 0.13
Metadata
Current evaluation
Ruff 0.13 lint-fix PR #1287 was closed unmerged after lint and test jobs failed; the PTH211 fixes landed separately via merged PR #1288 (commit 13382674).
Resolution: closed superseded
Reason: PR #1287 never merged - its lint and fast/slow test checks were failing and review status remained pending. The same Ruff 0.13 PTH211 work was completed and merged as canonical/craft-parts#1288 in commit 13382674 with two approvals and all checks green, so #1287 was closed in favour of that PR.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint && make test`?
- [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)?
---
Ruff 0.13 adds some more PTH checks, so we should just nip this in the bud now.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Ruff 0.13 lint-fix PR #1287 was closed unmerged after lint and test jobs failed; the PTH211 fixes landed separately via merged PR #1288 (commit 13382674). | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after failing lint and tests; the Ruff 0.13 PTH211 lint fixes were completed separately by merged PR canonical/craft-parts#1288. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged after Ruff 0.13 linting and test checks failed; the same PTH lint fix was merged separately in canonical/craft-application#901 (0a659742). | |
| qwen/qwen3.6-35b-a3b | — | — | Aimed to resolve ruff 0.13 linting violations, but the pull request was closed without merging. Failing CI checks and a pending review status led to its closure. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to resolve linting errors from Ruff 0.13 PTH checks. Updates code style to comply with the new linter version, passing all checks and changelog requirements. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/craft-parts#1288
(confidence 95%)
Merged PR 'style: fix ruff PTH211 errors' (commit 13382674) covering the same Ruff 0.13 PTH rule failures that #1287 attempted to fix.
-
Likely Fixed By:
canonical/craft-parts#1288
(confidence 85%)
Commit 13382674 'style: fix ruff PTH211 errors (#1288)' is the merged change that resolved the lint breakage addressed by #1287.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1288 style: fix ruff PTH211 errors | craft-parts | merged | Merged as commit 13382674: PR #1288 fixed Ruff 0.13 PTH211 errors across eight files (+29/-30), with all CI checks passing. | |
| #19 style: fix linting issues for ruff 0.12 | craft-artifacts | closed | PR #19 was closed unmerged after prolonged inactivity; its Ruff 0.12 lint fixes were abandoned. Later PR #20 was merged as commit 04cbdc0. | |
| #173 style: fix lint for ruff 0.12 | craft-archives | merged | Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed. | |
| #803 style: fix linting issues with ruff 0.12 | craft-application | merged | Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804. | |
| #20 style: fix ruff issue | craft-platforms | merged | Merged PR #20 fixed a Ruff linting issue in one file (+1/-3); resolution is commit 71a165d. | |
| #1737 style: fix linting for ruff 0.5 | charmcraft | merged | Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5. | |
| #1156 style: fix linting errors for ruff 0.12.0 | craft-parts | merged | Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed. | |
| #408 style: fix linting for ruff 0.12 | starbase | merged | Merged PR #408 as commit dc41fe4, applying a one-line style change that restored linting compatibility with Ruff 0.12. | |
| #357 style: fix lints from ruff 0.12 | craft-cli | merged | Merged as dd635c9, fixing new Ruff 0.12 lint errors across seven files (+11/-10); all CI checks passed. | |
| #33 lint: fix lint issues with newer ruff | craft-archives | merged | PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641. |