← Back to issue list

style: fix ruff issues with ruff 0.13

View original Github issue

Metadata

Project
craft-parts
Number
#1287
Type
pull request
State
closed
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Aimed to resolve ruff 0.13 linting violations, but the pull request was closed without merging. Failing CI checks and a pending review status led to its closure.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [x] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Ruff 0.13 adds some more PTH checks, so we should just nip this in the bud now.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Aimed to resolve ruff 0.13 linting violations, but the pull request was closed without merging. Failing CI checks and a pending review status led to its closure.
qwen3.6-35b-a3b-mtp-q6 Merged to resolve linting errors from Ruff 0.13 PTH checks. Updates code style to comply with the new linter version, passing all checks and changelog requirements.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#901 style: fix ruff 0.13 linting issues craft-application merged Merged after passing all CI checks and receiving approval from two reviewers. Resolves ruff 0.13 linting issues with a single-line change to one file.
86%
#19 style: fix linting issues for ruff 0.12 craft-artifacts closed Closed without merging. The ruff 0.12 linting fixes remained unreviewed and unmerged. CI checks for OSV-scanner, minimum dependencies, and linting continued to fail. The changes were abandoned after 393 days.
86%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged after approval by two reviewers. Resolves linting failures introduced by ruff 0.12 across 14 files. CI passed for fast tests, linting, and security scans, while slow test failures were tracked separately in #804.
83%
#56 lint: stricter ruff rules starbase closed Closed without merging. The pull request applying stricter ruff linting rules remained in pending review with no comments or CI checks and was abandoned.
82%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
82%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Merged after receiving approval from two reviewers and passing all CI checks. The update resolves linting errors introduced by ruff 0.12.0 across five files, adjusting code formatting to comply with the new linter version.
82%
#969 style: fix linting issues for ruff 0.9 craft-parts merged Merged a minor style fix addressing linting issues for ruff 0.9. Approved by two reviewers, passed CI checks, and updated two files with a net change of one line.
82%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged following two approvals and passing CI checks. Resolves lint compatibility for ruff 0.12 while preserving backwards compatibility with ruff 0.11. Applied via a minimal two-line adjustment.
82%
#357 style: fix lints from ruff 0.12 craft-cli merged Merged following approval from three reviewers and successful CI checks. Resolved lint errors introduced by Ruff 0.12 across seven files with minor code adjustments.
81%
#264 lint: format with ruff and fix ruff linting errors rockcraft closed Closed without merging. The ruff formatting and linting fixes were abandoned due to zero reviewer engagement and a pending dependency on issue #263.
81%