← Back to issue list

fix: install chisel for build-slices

View original Github issue

Metadata

Project
craft-parts
Number
#1737
Type
pull request
State
closed
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #1737 as commit 46fb937b: Chisel is now installed automatically when any part declares build-slices. The fix is recorded in craft-parts 2.37.1.

Resolution: closed resolved

Reason: PR #1737 was merged as commit 46fb937b. It adds Chisel as an automatic build snap when parts contain stage slices or build-slices, with the fix recorded in version 2.37.1.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint && make test`? - [ ] Have you added an entry to the changelog (`docs/reference/changelog.rst`)? --- Installs the chisel snap if any part declares build-slices. I found this bug while adding a spread test in craft-application. (CRAFT-5307)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #1737 as commit 46fb937b: Chisel is now installed automatically when any part declares build-slices. The fix is recorded in craft-parts 2.37.1.
stealth/space-bunny-alpha — closed resolved Added conditional installation of the Chisel snap when any part declares build-slices, addressing CRAFT-5307.
stealth/space-bunny-alpha
Impact: 45
Quick Win: 20
Complexity: 20
Confidence: 91
Actionability: 55
needs review Installs Chisel when parts declare build-slices. Approved by two reviewers; one review thread remains unresolved and the minimum-dependencies test fails.
qwen/qwen3.6-35b-a3b
Impact: 50
Quick Win: 32
Complexity: 20
Confidence: 70
Actionability: 80
close superseded Installs chisel snap when parts declare build-slices. All CI passing, pending review.

Update history

Date Change
closed
updated
updated
updated
updated
updated
created

Related work

  • Related To: canonical/craft-parts#1718 (confidence 98%)

    #1718 introduced build-slices cutting in the prologue; #1737 supplies the missing Chisel installation dependency.

Related issues

Issue Project State Summary Similarity
#649 Install chisel if parts use slices craft-parts closed Implemented as requested: PR #904 (commit 941164e1) makes craft-parts append chisel@latest/stable to extra build snaps when any part has stage-packages/build-packages slices. Later #914 added part_has_chisel_as_build_snap detection.
80%
#279 spec: add "stage-slices" for chisel slices craft-parts merged Merged PR #279, adding stage-slices so Chisel slices are declared separately from stage-packages; support is documented in Craft Parts 2.36.0.
77%
#1009 build(deps): update craft-parts rockcraft merged Merged craft-parts 2.26.0 via #1009 (commit 02755932), enabling chisel 1.3.
74%
#904 feat: add chisel as a build snap when stage-packages contain slices craft-parts merged Merged #904 via commit 941164e1, adding chisel@latest/stable only when stage-packages contain slices and no part already declares chisel.
73%
#792 ci: install chisel as a snap craft-parts closed Closed unmerged after inactivity; equivalent Chisel-snap CI and home-fixture changes were merged in craft-parts#793, fixing craft-parts#746.
73%
#281 unpack chisel slices craft-parts merged Merged PR #281 as commit 17c119ea, adding Chisel slice unpacking by passing slices from pull to build via PullState, with CI integration coverage.
71%
#1715 refactor: put chisel call in its own module craft-parts merged Merged PR #1715 in commit 0d154d79, extracting Chisel slice-cutting logic into its own module to separate cutting from Repository path normalization before build-slices support.
70%