← Back to issue list

lint: change ruff config to require `-> None`

View original Github issue

Metadata

Project
craft-parts
Number
#444
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Updated the ruff linter configuration to require explicit -> None return type hints. The change was merged after approval and passing CI checks, modifying one config file.

Suggested action:

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Updated the ruff linter configuration to require explicit -> None return type hints. The change was merged after approval and passing CI checks, modifying one config file.
qwen3.6-35b-a3b-mtp-q6 Merged a maintainer-submitted change updating the ruff linting configuration to enforce explicit -> None return type annotations. The update was integrated without additional discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#33 lint: fix lint issues with newer ruff craft-archives merged Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket.
78%
#236 build: update ruff settings craft-cli merged Merged following approval from two reviewers and passing CI checks. The change updates ruff configuration settings with a five-line modification to align linting rules.
78%
#319 style: update linting configuration for ruff 0.9 starbase merged Merged update to linting configuration for ruff 0.9. Approved by one reviewer and passed CI. The minimal two-file change was accepted after the author deferred an unrelated git_describe_command suggestion to a separate PR.
78%
#408 style: fix linting for ruff 0.12 starbase merged Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration.
77%
#68 lint: update ruff and fix linting craft-archives merged Merged into main following reviewer approval and passing CI. Updates ruff configuration and resolves linting issues across four files, maintaining 100% diff coverage with no overall coverage change.
77%
#101 ruff: remove type-checking guard blocks starbase merged Merged removal of type-checking guard blocks from ruff configuration per internal decision. Approved by reviewer, passed CI, and maintained 100% coverage with a minimal two-line diff.
77%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged following two approvals and passing CI checks. Resolves lint compatibility for ruff 0.12 while preserving backwards compatibility with ruff 0.11. Applied via a minimal two-line adjustment.
77%
#55 lint: stricter ruff rules starbase merged Merged stricter ruff linting rules. The change modifies one file with 23 additions and 9 deletions, enforces stricter configuration, and received reviewer approval before integration.
76%
#4981 style(lint): fix ruff 0.6 linting errors snapcraft merged Merged after receiving two approvals and passing CI checks. Resolves ruff 0.6 linting errors with a minimal one-file change.
76%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Merged after receiving approval from two reviewers and passing all CI checks. The update resolves linting errors introduced by ruff 0.12.0 across five files, adjusting code formatting to comply with the new linter version.
76%