← Back to issue list

lint: change ruff config to require `-> None`

View original Github issue

Metadata

Project
craft-parts
Number
#444
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #444 updated Ruff configuration to require explicit `-> None` return annotations, removing the permissive ANN401 setting.

Resolution: closed resolved

Reason: Merged into the project by PR #444; commit 56a80b07 records the Ruff configuration change requiring `-> None` return annotations.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #444 updated Ruff configuration to require explicit `-> None` return annotations, removing the permissive ANN401 setting.
stealth/space-bunny-alpha — closed resolved Merged #444, updating Ruff configuration to require explicit `-> None` return type hints.
qwen/qwen3.6-35b-a3b — — Updated the ruff linter configuration to require explicit -> None return type hints. The change was merged after approval and passing CI checks, modifying one config file.
qwen3.6-35b-a3b-mtp-q6 — — Merged a maintainer-submitted change updating the ruff linting configuration to enforce explicit -> None return type annotations. The update was integrated without additional discussion.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#907 style: adjust linting rules for ruff 0.12 rockcraft merged Merged into main as 186cb0fb, updating Ruff 0.12 settings to ignore PLC0415 and avoid unnecessary noqa comments.
74%
#21 lint: specify a single ruff version starbase merged Merged PR #21 as commit 0f3d7d0, pinning Ruff to one version so updates require Renovate or an explicit PR, avoiding unexpected CI breakage.
74%
#33 lint: fix lint issues with newer ruff craft-archives merged PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641.
73%
#11 lint: Specify a single ruff version craft-archives closed Superseded by the matching Ruff pin in commit 0f3d7d0 (recorded with #21), restricting updates to Renovate or explicit PRs.
73%
#481 build: update ruff settings rockcraft closed Ruff lint-config tweak PR closed unmerged; maintainer lengau closed it 2024-08-28 as superseded by #675 ("style(lint): replace pylint with ruff", merged as commit b7d70598).
73%
#319 style: update linting configuration for ruff 0.9 starbase merged Ruff 0.9 lint configuration update merged into main via commit 45ab05b (PR #319). The unrelated git_describe_command suggestion was deferred to PR #321.
73%
#101 ruff: remove type-checking guard blocks starbase merged Merged PR #101 as commit ab5e737, removing Ruff's required type-checking guard blocks after maintainers decided those blocks should not be mandated.
72%
#68 lint: update ruff and fix linting craft-archives merged Merged PR #68 as commit 8bb81ae, updating Ruff and fixing lint violations across four files after prerequisite #67.
72%
#510 build: update ruff settings craft-providers merged Merged PR #510 updated the Ruff configuration and was committed as bc34c1c.
72%
#173 style: fix lint for ruff 0.12 craft-archives merged Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed.
71%