ruff: remove type-checking guard blocks
Metadata
Current evaluation
Merged removal of type-checking guard blocks from ruff configuration per internal decision. Approved by reviewer, passed CI, and maintained 100% coverage with a minimal two-line diff.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
After internal discussion it was decided that mandating type-checking guard blocks is not preferred.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of type-checking guard blocks from ruff configuration per internal decision. Approved by reviewer, passed CI, and maintained 100% coverage with a minimal two-line diff. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by maintainer lengau, the change removes type-checking guard blocks after internal review decided against mandating them. Coverage remains at 100% and aligns with updated linting standards. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #33 lint: fix lint issues with newer ruff | craft-archives | merged | Merged to resolve linting failures introduced by a newer ruff version. Changes fix style checks across three files. Review approved, CI passed, and coverage remained unchanged. Additional unit tests were deferred to a separate tracking ticket. | |
| #68 lint: update ruff and fix linting | craft-archives | merged | Merged into main following reviewer approval and passing CI. Updates ruff configuration and resolves linting issues across four files, maintaining 100% diff coverage with no overall coverage change. | |
| #582 style: ruff 0.16 | starbase | merged | Merged following two approvals and successful CI checks. Updates ruff to 0.16 and adds a configuration to ignore the PLR0917 rule for tests. | |
| #444 lint: change ruff config to require `-> None` | craft-parts | merged | Updated the ruff linter configuration to require explicit -> None return type hints. The change was merged after approval and passing CI checks, modifying one config file. | |
| #236 build: update ruff settings | craft-cli | merged | Merged following approval from two reviewers and passing CI checks. The change updates ruff configuration settings with a five-line modification to align linting rules. | |
| #408 style: fix linting for ruff 0.12 | starbase | merged | Merged a one-line update to resolve linting errors for ruff 0.12. Approved by two reviewers and passed all CI checks before integration. | |
| #319 style: update linting configuration for ruff 0.9 | starbase | merged | Merged update to linting configuration for ruff 0.9. Approved by one reviewer and passed CI. The minimal two-file change was accepted after the author deferred an unrelated git_describe_command suggestion to a separate PR. | |
| #5574 style: ruff 0.12 | snapcraft | merged | Merged after two reviewer approvals. Updates codebase for ruff 0.12 compatibility. CI passed except a non-blocking OSV-scanner failure. Changes affect 8 files with 56 additions and 23 deletions. | |
| #1517 build: update ruff settings | charmcraft | merged | Merged update to ruff configuration settings. The one-file build adjustment received approval from two reviewers and was integrated without comments or CI issues. | |
| #4012 linters: migrate to ruff | snapcraft | merged | Migrated linters to Ruff with a legacy-specific ruff.toml. Approved by two reviewers, passed CI with 100% diff coverage, and merged into main with 167 additions and 35 deletions across 20 files. |