ruff: remove type-checking guard blocks
Metadata
Current evaluation
Merged PR #101 as commit ab5e737, removing Ruff's required type-checking guard blocks after maintainers decided those blocks should not be mandated.
Resolution: closed resolved
Reason: PR #101 was approved and merged into main as commit ab5e737. It removed Ruff's requirement for type-checking guard blocks following internal maintainer discussion.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the guidelines for contributing?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
-----
After internal discussion it was decided that mandating type-checking guard blocks is not preferred.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #101 as commit ab5e737, removing Ruff's required type-checking guard blocks after maintainers decided those blocks should not be mandated. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit ab5e737, removing Ruff’s mandated type-checking guard blocks after maintainers decided the guards were not preferred. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #101 in commit ab5e737, removing Ruff’s mandated type-checking guard blocks after maintainers decided they should not be required. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of type-checking guard blocks from ruff configuration per internal decision. Approved by reviewer, passed CI, and maintained 100% coverage with a minimal two-line diff. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged by maintainer lengau, the change removes type-checking guard blocks after internal review decided against mandating them. Coverage remains at 100% and aligns with updated linting standards. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #415 style: fix ruff 0.16 warning | craft-store | merged | Merged PR #415 as commit b24d684, adding a directive to ignore Ruff 0.16's new warning; all CI checks passed. | |
| #113 update ruff pre-commit | craft-platforms | merged | Merged #113, updating Ruff's pre-commit configuration; the change landed in commit 1740611. | |
| #55 lint: stricter ruff rules | starbase | merged | Merged PR canonical/starbase#55 as b5cda0d, tightening Ruff lint rules in one file (+23/-9) after maintainer approval. | |
| #68 lint: update ruff and fix linting | craft-archives | merged | Merged PR #68 as commit 8bb81ae, updating Ruff and fixing lint violations across four files after prerequisite #67. | |
| #444 lint: change ruff config to require `-> None` | craft-parts | merged | Merged PR #444 updated Ruff configuration to require explicit `-> None` return annotations, removing the permissive ANN401 setting. | |
| #173 style: fix lint for ruff 0.12 | craft-archives | merged | Merged PR #173 as commit 53d732e, fixing lint for Ruff 0.12 while retaining Ruff 0.11 compatibility; all CI checks passed. | |
| #1737 style: fix linting for ruff 0.5 | charmcraft | merged | Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5. | |
| #139 style: stricter ruff linters | starbase | merged | PR #139 was merged as commit a48d590, adding stricter Ruff lint rules across six files while retaining 100% test coverage. | |
| #33 lint: fix lint issues with newer ruff | craft-archives | merged | PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641. | |
| #20 style: fix ruff issue | craft-platforms | merged | Merged PR #20 fixed a Ruff linting issue in one file (+1/-3); resolution is commit 71a165d. |