← Back to issue list

lint: run `ruff --fix`

View original Github issue

Metadata

Project
craft-providers
Number
#289
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

PR #289 merged as commit 26c362e, running ruff --fix across 49 files and removing newly fixed rules from the ignore list as part of #287.

Resolution: closed resolved

Reason: PR #289 was approved and merged as commit 26c362e. Its lint fixes completed the Ruff cleanup begun in PR #288 and addressed work tracked by #287.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? ----- Run `ruff --fix` and remove the fixed rules from the ignore list. This builds on top of https://github.com/canonical/craft-providers/pull/288, so only the second commit needs review here. See https://github.com/canonical/craft-providers/issues/287. (CRAFT-1726)

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR #289 merged as commit 26c362e, running ruff --fix across 49 files and removing newly fixed rules from the ignore list as part of #287.
qwen/qwen3.6-35b-a3b — closed resolved Merged PR #289 that ran `ruff --fix` and removed fixed rules from the ignore list, addressing issue #287.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/craft-providers#287 (confidence 100%)

    The PR explicitly cites #287 as the broader synchronization issue it advanced.

  • Related To: canonical/craft-providers#288 (confidence 100%)

    PR #289 builds on the Ruff migration and lint-rule replacement introduced by merged PR #288.

Related issues

Issue Project State Summary Similarity
#68 lint: update ruff and fix linting craft-archives merged Merged PR #68 as commit 8bb81ae, updating Ruff and fixing lint violations across four files after prerequisite #67.
79%
#1465 style: fix linting issues for newer ruff craft-parts merged Merged #1465 as a58695ef, fixing five files (+13/-6) for compatibility with newer Ruff; all CI checks passed.
78%
#33 lint: fix lint issues with newer ruff craft-archives merged PR #33 merged as commit c2a6687, fixing new lint failures introduced by a newer Ruff release across3 files (+5/-3). Maintainer deferred extra unit tests to CRAFT-1641.
78%
#423 style(lint): fix ruff 0.6.0 linting errors craft-application merged Merged PR #423 as commit 2f56f14b, applying ruff check --fix across 21 files (+70/-70) to clear the new Ruff 0.6.0 lint errors. Approved by 2 maintainer reviewers.
78%
#1825 style(lint): fix ruff 0.6.0 linting errors charmcraft merged Merged PR #1825 as commit 7aa2965b, applying Ruff 0.6.0 autofixes across 31 files to resolve linting errors.
78%
#815 fix linting issues for ruff 0.6 craft-parts merged Merged PR #815, applying Ruff 0.6 autofixes and manual lint corrections across 44 files (+98/-98).
78%
#1737 style: fix linting for ruff 0.5 charmcraft merged Merged PR #1737 as commit 8994523e, updating one file (+2/-6) to fix linting under Ruff 0.5.
77%
#1577 style(lint): enable some previously-ignored ruff rules charmcraft merged Merged PR #1577 in commit 1b650062, enabling previously ignored Ruff rules and applying related lint/style changes across 10 files.
77%
#1156 style: fix linting errors for ruff 0.12.0 craft-parts merged Ruff 0.12.0 lint fixes merged as PR #1156 (commit eb82b792), correcting style violations in 5 files (+9/-12) after the ruff-pre-commit v0.12.0 bump in #407; all CI checks passed.
77%
#803 style: fix linting issues with ruff 0.12 craft-application merged Merged via commit 5e15ff09, fixing Ruff 0.12 lint failures across 14 files. A separate integration-test failure was fixed by #804.
76%