chore(lint): silent false positive for PLC0206
Metadata
Current evaluation
PR #575 (silencing Ruff PLC0206 false positives, bumping ruff in pre-commit) was not merged; the author closed it as duplicated by #580, which was merged as commit 97347705 fixing ruff 0.8 lint issues.
Resolution: closed superseded
Reason: The PR was left unmerged with changes requested, and the author (dariuszd21) commented "Duplicated by: #580" on 2024-12-03 before closing it. PR #580 "style(ruff): fix linting issues from ruff update" was merged to main as commit 97347705, delivering the equivalent ruff 0.8 lint fixes.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [ ] Have you followed the guidelines for contributing?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox`?
Ruff from version `0.8.0` marks incorrectly loops that writes to the dict, as those who should use `.items()`. This PR silences this error for those specific cases, additionally bumps `ruff` in `pre-commit` and fixes warning for `pyproject.toml`.
For reference: https://github.com/astral-sh/ruff/issues/14585
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | PR #575 (silencing Ruff PLC0206 false positives, bumping ruff in pre-commit) was not merged; the author closed it as duplicated by #580, which was merged as commit 97347705 fixing ruff 0.8 lint issues. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed as a duplicate of merged PR #580, which resolved Ruff linting issues after the Ruff update in commit 97347705. | |
| qwen/qwen3.6-35b-a3b | — | — | Aims to silence a false positive Ruff lint error and update pre-commit. The request was closed and duplicated by PR #580, which implemented the same changes. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/craft-application#580
(confidence 96%)
Author explicitly marked #575 as duplicated by #580, which merged as commit 97347705
-
Likely Fixed By:
canonical/craft-application#580
(confidence 85%)
Merged PR addressing the same Ruff 0.8 lint failure cleanup and pre-commit ruff bump
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #700 chore: update ruff | craft-parts | merged | Merged PR #700 updated Ruff configuration across four files, superseding #699; a follow-up lint issue was fixed in merged PR #702. | |
| #36 chore: switch to ruff | craft-platforms | merged | Merged PR #36 as commit ce5f6b9, switching linting and formatting to Ruff, updating configuration, and applying fixes across seven files. | |
| #965 chore(lint): enable passing Ruff rules | craft-providers | closed | PR #965 (enabling Ruff rules D215, A003, PLW1641) was closed unmerged: @bepri rejected it because the ignores are intentional for uniformity across Canonical repos. Rules remain in pyproject.toml ignore list. | |
| #1347 chore(deps): update ruff and fix new linting errors | charmcraft | merged | Ruff pre-commit hook was bumped and resulting lint errors auto-fixed across 10 files (+40/-37). PR #1347 was merged by lengau on 2023-10-23 as commit 34018724. | |
| #115 chore(deps): update ruff and fix linting issue | craft-application | merged | Routine housekeeping PR bumping the ruff pre-commit hook and fixing the resulting lint error (2 files, +2/-4). Approved by 2 reviewers and merged into main as commit 59ab0049; Codecov's -0.10% coverage note was non-blocking. | |
| #651 chore(linter): refine ruff configurations | craft-parts | merged | Merged PR #651 (commit 658dde3c) re-added previously removed Pylint (PLR) rules to the Ruff lint config in pyproject.toml, now present as [tool.ruff.lint.pylint] and per-file ignores. | |
| #103 chore: fix new lints from ruff 0.12 | craft-grammar | merged | Merged PR #103 as a3ef1dd, updating Ruff to 0.12 and fixing resulting lint errors across four files; cherry-picked from canonical/starbase#409. | |
| #22 chore(lint): update ruff and config | starbase | merged | Merged in canonical/starbase#22 via commit f3d35a6, updating Ruff and its config to ignore excessive test-function arguments (PLR0913). | |
| #907 style: adjust linting rules for ruff 0.12 | rockcraft | merged | Merged into main as 186cb0fb, updating Ruff 0.12 settings to ignore PLC0415 and avoid unnecessary noqa comments. | |
| #119 chore(deps): update dependency lint/ruff to v0.0.284 | starbase | merged | Renovate dependency bump PR #119 (lint/ruff 0.0.272 -> 0.0.284 in the ruff pre-commit hook) was approved and merged into main as commit be3ae62; +1/-1 line, no source changes. |