← Back to issue list

chore(lint): silent false positive for PLC0206

View original Github issue

Metadata

Project
craft-application
Number
#575
Type
pull request
State
closed
Author
dariuszd21
Labels
Created
Updated
Closed

Current evaluation

Aims to silence a false positive Ruff lint error and update pre-commit. The request was closed and duplicated by PR #580, which implemented the same changes.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the guidelines for contributing? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox`? Ruff from version `0.8.0` marks incorrectly loops that writes to the dict, as those who should use `.items()`. This PR silences this error for those specific cases, additionally bumps `ruff` in `pre-commit` and fixes warning for `pyproject.toml`. For reference: https://github.com/astral-sh/ruff/issues/14585

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Aims to silence a false positive Ruff lint error and update pre-commit. The request was closed and duplicated by PR #580, which implemented the same changes.
qwen3.6-35b-a3b-mtp-q6 Superseded by pull request #580. The lint rule suppression and Ruff version bump were consolidated into the duplicate PR instead.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#965 chore(lint): enable passing Ruff rules craft-providers closed Rejected. The proposal to enable specific Ruff lint rules was declined because they are intentionally ignored to maintain uniformity across repositories, not due to current code violations.
74%
#715 chore(lint): use ruff from snap craft-parts merged Merged a linting chore switching to ruff from snap. Approved by two reviewers, the change modifies three files with a net reduction of two lines.
73%
#651 chore(linter): refine ruff configurations craft-parts merged Merged into main after passing CI and receiving two approvals. The change restores previously removed Pylint rules to the Ruff linter configuration, with one rule temporarily commented out pending upstream updates.
73%
#543 chore(lint): remove isort rockcraft merged Merged a pull request replacing isort with Ruff for linting. The update modifies three files to utilize Ruff's capabilities, streamlining the configuration. Approved by two reviewers.
71%