fix(auth): error more nicely on keyring errors
Metadata
Current evaluation
Merged to improve keyring unlock error handling by catching additional failures and raising them as KeyringUnlockError. Approved by three reviewers, passed all CI checks, and resolves issue #58.
Suggested action: —
No scores available.
Issue body
This catches more keyring errors while unlocking and raises them with the KeyringUnlockError.
CRAFT-5224
Fixes #58
---
- [x] I've followed the [contribution guidelines](https://github.com/canonical/craft-store/blob/main/CONTRIBUTING.md).
- [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/).
- [x] I've successfully run `make lint && make test`.
- [x] I've added or updated any relevant documentation.
- [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing.
- [x] I've updated the relevant release notes.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged to improve keyring unlock error handling by catching additional failures and raising them as KeyringUnlockError. Approved by three reviewers, passed all CI checks, and resolves issue #58. | |
| qwen3.6-35b-a3b-mtp-q6 |
Staleness:
5
Complexity:
15
Confidence:
90
|
needs review | Catches additional keyring errors during unlocking and raises them as KeyringUnlockError. Includes lint, test, and documentation updates. Awaiting maintainer review. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #170 fix: catch keyring locked error | craft-store | merged | Merged to resolve issue #166 by catching the keyring locked error. Approved by two reviewers with a two-line change in one file. | |
| #75 auth: handle keyring unlocking errors | craft-store | merged | Merged to address CRAFT-1622. Adds error handling for keyring unlocking failures by catching exceptions and raising appropriate Craft-store errors. Approved by two reviewers and passed CI. | |
| #163 fix: workaround for keyring 25 incompatibility | craft-store | merged | Merged a one-line workaround to resolve keyring 25 incompatibility. Approved by two reviewers and passed CI checks, addressing issue #162. | |
| #206 fix: make compatible with keyring 25 | craft-store | merged | Merged to resolve issue #162 by updating code for keyring 25 compatibility. Approved by three reviewers, the change modifies two files with minimal adjustments (+3/-2 lines) and was successfully integrated. |