← Back to issue list

fix(auth): error more nicely on keyring errors

View original Github issue

Metadata

Project
craft-store
Number
#390
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #390 (commit d87f1bd) broadens keyring error handling, wrapping more keyring failures as KeyringUnlockError. Fixes #58 and ships in craft-store 3.4.0.

Resolution: closed resolved

Reason: PR #390 was approved by 3 reviewers and merged to main as commit d87f1bd, with all CI checks passing. It widens the caught keyring exceptions (KeyringLocked plus KEYRING_EXCEPTIONS) around unlock/credential operations and re-raises them as errors.KeyringUnlockError; the changelog for 3.4.0 records 'Translate keyring initialization failures into KeyringUnlockError when the keyring cannot be unlocked', and it closes issue #58.

Evaluated by: mr-cal-bot

No scores available.

Issue body

This catches more keyring errors while unlocking and raises them with the KeyringUnlockError. CRAFT-5224 Fixes #58 --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/craft-store/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [x] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #390 (commit d87f1bd) broadens keyring error handling, wrapping more keyring failures as KeyringUnlockError. Fixes #58 and ships in craft-store 3.4.0.
stealth/space-bunny-alpha — closed resolved Merged PR #390 (commit d87f1bd) broadens keyring error handling in craft-store, wrapping more keyring failures as KeyringUnlockError; fixes issue #58 and ships in release 3.4.0.
qwen/qwen3.6-35b-a3b — — Merged to improve keyring unlock error handling by catching additional failures and raising them as KeyringUnlockError. Approved by three reviewers, passed all CI checks, and resolves issue #58.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/craft-store#58 (confidence 98%)

    Issue 'Keyring failures give bad error messages' is the bug report explicitly fixed by this PR via 'Fixes #58'.

Related issues

Issue Project State Summary Similarity
#58 Keyring failures give bad error messages craft-store closed Keyring failures now raise craft-store's KeyringUnlockError with clearer messaging, fixed by PR #390 (commit d87f1bd).
84%
#75 auth: handle keyring unlocking errors craft-store merged Merged PR #75 as commit 74a2ed4, adding keyring unlock error handling that raises a Craft-store error instead of exposing the backend exception.
83%
#170 fix: catch keyring locked error craft-store merged Merged PR #170 added handling for locked keyring errors, fixing #166; merged as commit ee19448.
75%
#206 fix: make compatible with keyring 25 craft-store merged Merged canonical/craft-store#206 in commit bdcbf0e, adding a two-file compatibility fix for keyring 25 and resolving issue #162.
73%
#163 fix: workaround for keyring 25 incompatibility craft-store merged Merged a one-line workaround for keyring 25 incompatibility in commit 6ef080b, addressing canonical/craft-store#162.
71%