← Back to issue list

fix: update packages typing

View original Github issue

Metadata

Project
craft-store
Number
#405
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged fix updating packages typing to a mapping, resolving a charmcraft login validation error for string charm names. Approved by two reviewers and passed CI. Prepares the craft-store release.

Suggested action:

No scores available.

Issue body

Updates the packages type to be a mapping. If you pass it strings, it errors with: ``` charmcraft login --export creds.txt --charm home-assistant Email address: callahan.kovacs@canonical.com Password: 'home-assistant' is not of type 'object' at /packages/0 Detailed information: api-error Full execution log: '/home/callahan.kovacs@canonical.com/.local/state/charmcraft/log/charmcraft-20260715-143035.881847.log' ``` Also prepares for the first release of craft-store in over a year! (CHARMCRAFT-667) --- - [x] I've followed the [contribution guidelines](https://github.com/canonical/craft-store/blob/main/CONTRIBUTING.md). - [x] I've signed the [CLA](http://www.ubuntu.com/legal/contributors/). - [x] I've successfully run `make lint && make test`. - [ ] I've added or updated any relevant documentation. - [ ] In documents I changed, I [added a meta description](https://canonical-starflow.readthedocs-hosted.com/how-to/add-a-page-meta-description/) if one was missing. - [x] I've updated the relevant release notes.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged fix updating packages typing to a mapping, resolving a charmcraft login validation error for string charm names. Approved by two reviewers and passed CI. Prepares the craft-store release.
qwen3.6-35b-a3b-mtp-q6
Staleness: 0
Complexity: 15
Confidence: 90
needs review Fixes a type validation error where string values were incorrectly passed to the packages field, requiring an object mapping instead. Currently awaiting initial review.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1619 fix: use charmcraft package version charmcraft merged Merged after approval from two reviewers. Implements a one-line fix to use the charmcraft package version, updating a single file to resolve the versioning configuration.
77%
#580 requirements: update to latest released versions charmcraft merged Merged update to latest released dependency versions, introducing craft-store for improved Charmhub error handling. Approved by one reviewer with passing CI checks across two files.
76%
#1641 build(deps): bump internal libraries charmcraft merged Merged after three approvals. Updated craft-providers and craft-store to match snapcraft 7.x minor versions. A reviewer suggested implementing debugging logic in charmcraft for future use.
73%
#2518 fix: get non-store CI working on Charmcraft 2.7 charmcraft merged Merged to fix non-store CI configuration for Charmcraft 2.7. Adjusted test setup and permissions without altering application functionality. Approved by two reviewers and integrated alongside a companion permissions update.
73%
#1974 Check `charmcraft.yaml` for charm name charmcraft merged Merged changes to validate the charm name in charmcraft.yaml, resolving issue 1973. It passed CI, received two approvals, and was merged after the author corrected a CLA email mismatch via force push.
72%
#289 fix: fix issues found in common.mk with charmcraft starbase merged Merged a fix for charmcraft issues in common.mk. Approved by two reviewers with zero unresolved comments. Changed two files, adding 11 and removing 7 lines.
72%
#1622 fix: reorganise charmcraft.yaml preprocessing charmcraft merged Merged following two approvals and passing CI. Reorganized charmcraft.yaml preprocessing to apply extensions on raw data, assign default parts to charms with bases, and enforce dictionary type for parts. Modified 5 files (+27/-14 lines).
72%
#295 Update charm library template for correct command to publish or update libraries charmcraft merged Merged a fix to update the charm library template with the correct command, replacing the non-existent charmcraft push-lib. Approved by two reviewers with minimal changes.
71%
#105 feat: charmcraft/pack with typescript craft-actions merged Merged after approval and passing CI checks. Rewrites the charmcraft/pack command in TypeScript to align with other pack commands, addressing CRAFT-5205. The change modifies 14 files.
71%
#2034 fix(store): nicer error message when getting nonexistent libs charmcraft merged Merged a fix that replaces a cryptic charmhub error with a clearer message when a charm library is missing. Approved by two reviewers, the change resolves issue #1754 and CRAFT-3353, modifying two files with 35 additions and 3 deletions.
71%