← Back to issue list

lint: run shellcheck on spread.yaml

View original Github issue

Metadata

Project
rockcraft
Number
#201
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Pull request to run shellcheck on spread.yaml was approved, passed CI, and merged with a four-line change across two files.

Suggested action:

No scores available.

Issue body

- [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Pull request to run shellcheck on spread.yaml was approved, passed CI, and merged with a four-line change across two files.
qwen3.6-35b-a3b-mtp-q6 Merged to add shellcheck linting for spread.yaml, enhancing shell script validation in the project's configuration and testing workflows.
qwen3.6-35b-a3b-mtp-q6 Merged changes to integrate shellcheck linting into the spread.yaml configuration, ensuring shell script syntax validation during CI runs.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#9 lint spread tests with shellcheck snapcraft-rocks closed Shellcheck linting for spread tests was implemented via merged pull request #14. The issue is closed.
83%
#196 lint: add shellcheck and spread-shellcheck linters rockcraft merged Merged to add shellcheck and spread-shellcheck linters to the GitHub workflow. Includes minor compliance fixes. Approved by two reviewers with passing CI checks. Author inquired about documenting the shellcheck snap dependency.
80%
#2381 tools: copy in spread-shellcheck from snapd snapcraft merged Merged the spread-shellcheck tool from snapd to enable shellcheck integration for spread tests. Approved by reviewer, passed CI, and updated 74 files with 508 additions and 58 deletions.
76%
#573 ci: run spread tests on 'spread-installed' runners rockcraft merged Merged a two-file, four-line CI configuration change to run spread tests on spread-installed runners. Approved by three reviewers and integrated.
74%
#127 Fix spread tests imagecraft merged Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
72%
#1029 fix(testing): error early if spread.yaml is invalid. craft-application merged Merged after two approvals. Adds early validation to fail tests immediately if spread.yaml is invalid. CI passed except for an unrelated snap-test failure, which was overridden.
72%
#565 feat(testing): process simplified spread.yaml craft-application merged Merged to resolve issue #560. Processes a user-supplied simplified spread.yaml into a complete project file for the spread testing framework. Approved by two reviewers, passed CI, and modified 11 files.
71%
#1083 ci: fix spread test missing PATH charmcraft merged Merged a fix for a CI spread test missing the PATH variable. The change updated four files and received reviewer approval. Post-merge validation confirmed the spread tests for configure and remove passed successfully.
71%
#143 docs: make docs spread-testable craft-store merged Merged documentation spread-testing infrastructure setup. Approved by two reviewers and passing CI, the change modifies six files (+136/-41 lines) to enable local spread test execution for documentation.
70%
#4529 Spread update snapcraft merged Merged after approval by two reviewers and passing CI checks. The update modifies spread configuration across three files, adding 36 and removing 40 lines. Code coverage tests passed.
70%