tools: copy in spread-shellcheck from snapd
Metadata
Current evaluation
Merged PR #2381 as cce7842e8, adding snapd's spread-shellcheck tool, expanding ShellCheck coverage to spread tests, and correcting affected glob patterns.
Resolution: closed resolved
Reason: PR #2381 was approved and merged into the master branch as commit cce7842e8. Repository history confirms the change as "tools: broader shellcheck including spread."
Evaluated by: mr-cal-bot
No scores available.
Issue body
We're considering packing spread-shellcheck into a snap, or maybe
seeing if shellcheck is interested, but meanwhile I thought I'd offer
it to you guys.
Here's how you use it:
1. `snap install --edge shellcheck`
2. `./tools/spread-shellcheck.py spread.yaml tests/spread/`
---
Most of the changes are minor; I purposefully didn't stop to think why you were comparing fixed strings using a regexp matcher. However if you search for `*/` and `*p` you'll find some tests I had to change a bit because of mis-using globs; I hope I understood what you thought you were doing :-)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #2381 as cce7842e8, adding snapd's spread-shellcheck tool, expanding ShellCheck coverage to spread tests, and correcting affected glob patterns. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as cce7842e8, PR #2381 brought snapd's spread-shellcheck into Snapcraft, expanded ShellCheck coverage to spread tests, and corrected affected glob patterns. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged the spread-shellcheck tool from snapd to enable shellcheck integration for spread tests. Approved by reviewer, passed CI, and updated 74 files with 508 additions and 58 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged spread-shellcheck from snapd into snapcraft. The update adds a Python script to run shellcheck on spread tests, incorporating minor adjustments and glob pattern fixes. Successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #9 lint spread tests with shellcheck | snapcraft-rocks | closed | Added ShellCheck linting for spread tests via merged PR canonical/snapcraft-rocks#14 ("chore(ci): add shellcheck and yamllint"), which also enabled yamllint. Maintainer tigarmo closed the issue with "Fixed by #14". | |
| #196 lint: add shellcheck and spread-shellcheck linters | rockcraft | merged | Merged PR #196 as b7c4c794, adding ShellCheck and spread-shellcheck to GitHub CI plus minor compliance fixes. | |
| #201 lint: run shellcheck on spread.yaml | rockcraft | merged | Merged PR #201 in commit c90598eb, enabling ShellCheck linting for spread.yaml through a small lint-configuration update. | |
| #521 test(spread): add an improved snap inspector test | fetch-service | merged | Merged in PR #521 (commit 06cd210), adding a more realistic snapd setup to the spread snap inspector test and exposing additional snapd network requests. | |
| #240 tests: check for submodules before running spread | rockcraft | merged | Merged PR #240 as commit 3d940f71, adding a preflight check so spread tests report a clear error when the snapd-testing-tools submodule is missing. | |
| #5841 Include "build snapd snap" test in test suite | snapcraft | closed | Added spread coverage for building snapd and base snaps in merged PR #5845 (commit fb8c81e8f). | |
| #4105 tests: check for submodules before running spread | snapcraft | merged | Merged PR #4105 in commit 7921b04ed, adding a Spread preflight check that stops with a clear error when the snapd-testing-tools submodule is missing. | |
| #2182 tests: add spread suite for autotools plugin | snapcraft | merged | PR #2182 merged to master as commit eadd86729, consolidating the Autotools plugin and snapd tests into a single Spread suite and resolving LP bug #1783825. | |
| #1783825 Move Autotools plugin tests to spread | snapcraft (launchpad) | closed | Autotools and snapd plugin integration tests were consolidated into a Spread suite by merged PR #2182 (commit eadd86729), resolving LP #1783825. |