refactor: remove old "init" command implementation
Metadata
Current evaluation
Merged PR #1520 in commit 97fa9229, removing 248 lines of obsolete init command code after the craft-application transition.
Resolution: closed resolved
Reason: PR #1520 was approved and merged as commit 97fa9229, deleting the superseded pre-transition init implementation across four files.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This is no longer necessary after the craft-application transition
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1520 in commit 97fa9229, removing 248 lines of obsolete init command code after the craft-application transition. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1520 as commit 97fa9229, removing Charmcraft’s obsolete init implementation after the craft-application transition; 4 files changed (+1/-248). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1520 as commit 97fa9229, removing Charmcraft's obsolete init command implementation after craft-application took over initialization. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1520 as commit 97fa9229, removing the obsolete 248-line init command implementation after Charmcraft transitioned to craft-application. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1520 (commit 97fa9229) deleted Charmcraft's legacy init command implementation (~248 lines across 4 files), obsolete after the craft-application transition. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1520, removing Charmcraft's obsolete init command implementation after the craft-application transition; four files changed (+1/-248 lines). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #1520, removing 248 lines of obsolete init command code after the craft-application transition. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged refactoring changes that remove the legacy init command implementation, rendering it redundant after the craft-application transition. |
Update history
No update history recorded yet.
Related work
-
Related To:
charmcraft#1399
(confidence 90%)
The craft-application rebase introduced the newer application-layer init implementation that made the old code obsolete.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1571 refactor: remove unused clean command implementation | charmcraft | merged | Merged PR #1571 as commit 053d5a2d, removing the obsolete Charmcraft clean command and regression tests after craft-application took over clean handling. | |
| #1340 feat(craft-app): move init command | charmcraft | merged | PR #1340 by lengau merged, relocating charmcraft's init command into craft-application (with the init service/command/tests) plus lint fixes (+500/-343, 18 files). Later cleanup commit 97fa9229 (#1520) removed the old implementation. | |
| #5129 refactor: use init command from craft-application | snapcraft | merged | Merged PR #5129 (de05a733d) replaced Snapcraft’s init command with craft-application’s, fixed #5098, and added name, profile, and project-dir options. | |
| #1153 Move the init command to craft-application | charmcraft | closed | Init moved to craft-application and was adopted by Charmcraft in merged PR canonical/charmcraft#1340; upstream PR canonical/craft-application#522 landed it in commit f2a4becf. | |
| #395 refactor: merge feature/craft-application | rockcraft | merged | Merged PR #395 into main, completing the breaking migration to craft-application 1.0.0 and resolving seven linked migration and command issues. | |
| #4830 refactor: migrate commands to craft-application | snapcraft | merged | Merged #4830 as commit 0bee3723c, migrating remaining commands to core24/craft-application; init, list-plugins, and command reference docs now use core24. | |
| #1419 refactor: remove non craft-application analyze command | charmcraft | merged | Merged PR #1419 as c3ae865e, removing the accidentally retained non-craft-application analyze command while keeping the craft-application version. | |
| #360 Migrate non-lifecycle commands to craft-application | rockcraft | closed | Resolved by merged PR #761 (commit 484099f5), which adopted craft-application’s upstream Init command/service and added --project-dir support. | |
| #353 refactor(cli): add scaffolding for craft-application | rockcraft | merged | PR #353 merged into feature/craft-application as 5cff2f1c, adding craft-application scaffolding with a legacy-runner fallback. | |
| #1572 refactor: remove unused extension command implementations | charmcraft | merged | Merged PR #1572 removed Charmcraft’s unused extension command implementations and moved their tests to craft-application; remote-build test fixes were handled separately in #1573. |