← Back to issue list

refactor: remove old "init" command implementation

View original Github issue

Metadata

Project
charmcraft
Number
#1520
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248.

Suggested action:

No scores available.

Issue body

This is no longer necessary after the craft-application transition

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a refactoring PR removing the old "init" command after the craft-application transition. Approved by two reviewers with passing CI, the change modified four files, adding one line and deleting 248.
qwen3.6-35b-a3b-mtp-q6 Merged refactoring changes that remove the legacy init command implementation, rendering it redundant after the craft-application transition.
qwen3.6-35b-a3b-mtp-q6 Merged a refactor to remove the legacy init command implementation, as it became unnecessary following the craft-application transition.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1571 refactor: remove unused clean command implementation charmcraft merged Merged refactoring that removes the unused custom clean command and associated regression tests, as the project now uses the craft-application clean command. Approved by three reviewers, passed CI, and modified four files.
84%
#5129 refactor: use init command from craft-application snapcraft merged Merged a refactor replacing Snapcraft's init command with craft-application's implementation. Introduces name, profile, and project-dir parameters, resolves #5098, passed CI, and received two approvals across 23 changed files.
82%
#1419 refactor: remove non craft-application analyze command charmcraft merged Merged refactoring that removes a superfluous non-craft-application version of the analyze command. Approved by three reviewers with zero unresolved comments. Modified seven files, deleting 339 lines and adding 135.
81%
#4682 refactor(app): use more code from craft-app snapcraft merged Merged a refactoring update consolidating app code by leveraging more craft-app functionality. Approved by two reviewers, passed CI and coverage checks, and modified three files with a net reduction of 13 lines.
80%
#1572 refactor: remove unused extension command implementations charmcraft merged Merged refactoring that removes unused extension command implementations. Tests were relocated to craft-application, with remote build fixes tracked in #1573. Approved by three reviewers, the change reduced 161 lines across six files.
80%
#1340 feat(craft-app): move init command charmcraft merged Merged maintainer PR moving the craft-app init command. Includes required lint fixes, approved by three reviewers, and modifies 18 files (+500/-343 lines).
79%
#856 refactor: use craft-application 5 rockcraft merged Merged after three reviewers approved. The change refactored the codebase to adopt craft-application version 5, updating 49 files with 959 additions and 915 deletions. All checks passed.
79%
#4830 refactor: migrate commands to craft-application snapcraft merged Merged following three approvals and passing CI. Migrates remaining commands to core24/craft-application, updating snapcraft init to generate core24 files, correcting list-plugins output, and refreshing command docs. Resolves #4742.
77%
#395 refactor: merge feature/craft-application rockcraft merged Merged feature/craft-application into main, completing Rockcraft's migration to craft-application 1.0.0. The refactoring modified 99 files, resolved multiple issues, and introduced breaking changes. Approved by two reviewers with passing CI.
77%
#521 refactor: port code to latest craft-app update rockcraft merged Merged following two approvals and passing CI. Refactored image and package services to replace platform/build-for with the build plan, aligning with craft-application 2.3.0. Updates span 14 files (+106/-71 lines).
76%