added test for git sources in the get() method in snapcraft/sources.py
Metadata
Current evaluation
Closed unmerged; its Git-source tests were reworked and merged through successor PR #233 in commit f909dc292.
Resolution: closed superseded
Reason: PR #217 was closed without being merged after extensive requested changes and unresolved CI feedback. The focused Git-source tests were delivered by successor PR #233 and merged as commit f909dc292.
Evaluated by: mr-cal-bot
No scores available.
Issue body
No description provided.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed unmerged; its Git-source tests were reworked and merged through successor PR #233 in commit f909dc292. | |
| stealth/space-bunny-alpha | — | closed superseded | Git-source tests were landed through successor PR #233, merged as f909dc292 after #217 was closed unmerged. | |
| qwen/qwen3.6-35b-a3b | — | — | Contributor submitted a test for git sources, but the PR closed without merging. Reviewers requested copyright updates, PEP8 fixes, and commit squashing. The author struggled with git rebase and abandoned the PR to start over. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Adding a test for git sources was closed without merging. Following review feedback and CI failures, the contributor struggled with git squashing and abandoned the work to recreate it. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#233
(confidence 100%)
Successor PR merged the Git-source tests in commit f909dc292.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #216 Added test for sources.py | snapcraft | closed | Closed unmerged; its Git-source test was incorporated into merged #233 via commit 106eb8e2d (merge f909dc292). | |
| #1534411 Needs Test for Git sources | snapcraft (launchpad) | closed | Git-source unit coverage was added by canonical/snapcraft PR #233 and merged as f909dc292 (commit 106eb8e2d), resolving Launchpad #1534411. | |
| #233 added test for git sources in sources.py | snapcraft | merged | Merged PR adding unit tests for Git sources in sources.py. Reviewer questions on a pull() assertion were resolved as no-ops, and the PR was merged after approval. | |
| #964 sources: refactor git source into module. | snapcraft | merged | Merged PR #964 (commit f9ee3f034) by maintainer kyrofa, extracting the Git source handler out of sources.py into snapcraft/sources/_git.py as part of the sources refactor series for LP #1648906. | |
| #1614520 parser fails when getting git sources that have merge conflicts | snapcraft (launchpad) | closed | Fixed by snapcore/snapcraft#1052, merged as commit d22880fdc, making Git pulls more resilient to history changes and merge conflicts. | |
| #1640675 Add source option for git submodules | snapcraft (launchpad) | closed | Feature request implemented: source-submodules added to git sources, merged as snapcraft PR #3629 (383c1f1ce) and craft-parts PR #169 (3891f255); shipped in Snapcraft 7 and 8. Maintainer closed the2016 Launchpad bug as done. |