update gradle plugin to use get_build_properties
Metadata
Current evaluation
Launchpad bug #1649988 reported by ~matt-aguirre was fixed by snapcraft PR #975 (commit 536f18c6e, "gradle plugin: implement get_build_properties()"), merged into master; the demo snapcraft.yaml was also set to grade: stable. Bug closed as fixed.
Resolution: closed resolved
Reason: The author pointed to snapcore/snapcraft PR #975, which was merged as commit 536f18c6e implementing get_build_properties() in the Gradle plugin (plus tests and the demos/gradle grade: stable change), directly addressing the bug. PR #974 was the separate Maven plugin fix for bug #1649986.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the gradle.py plugin to use the get_build_properties() method instead of modifying the schema.
Also set 'grade: stable' in the demos/gradle/snapcraft.yaml file.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Launchpad bug #1649988 reported by ~matt-aguirre was fixed by snapcraft PR #975 (commit 536f18c6e, "gradle plugin: implement get_build_properties()"), merged into master; the demo snapcraft.yaml was also set to grade: stable. Bug closed as fixed. | |
| stealth/space-bunny-alpha | — | closed resolved | Gradle build-property handling was fixed by merged PR #975 (commit 536f18c6e), using get_build_properties() instead of modifying the schema. | |
| stealth/space-bunny-alpha | — | closed resolved | Gradle now uses get_build_properties() instead of modifying the schema, and its demo is marked grade: stable. PR #975 merged as commit 536f18c6e. | |
| qwen/qwen3.6-35b-a3b | — | — | Implemented gradle.py update to use get_build_properties() instead of schema modification, and set grade: stable in the demo snapcraft.yaml. Closed as fixed. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved and closed after updating gradle.py to use get_build_properties() instead of schema modification, and setting grade: stable in the demo configuration. | |
| qwen/qwen3.6-35b-a3b | — | — | Updated the gradle plugin to use get_build_properties() instead of schema modification, and set grade stable in the demo config. The issue was closed after implementation. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Implemented changes to the gradle plugin by replacing schema modification with get_build_properties() and set grade: stable in the demo snapcraft.yaml. Issue closed. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
canonical/snapcraft#975
(confidence 97%)
Merged PR implementing get_build_properties() for the Gradle plugin; commit 536f18c6e.
-
Related To:
canonical/snapcraft#974
(confidence 60%)
The other PR cited in the comments; it fixed the Maven plugin for separate LP bug #1649986, not this Gradle bug.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #1649986 update maven plugin to use get_build_properties | snapcraft (launchpad) | closed | External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests. | |
| #975 Updated gradle plugin to use get_build_properties() | snapcraft | merged | External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. |