Updated gradle plugin to use get_build_properties()
Metadata
Current evaluation
External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series.
Resolution: closed resolved
Reason: The PR was merged into master as commit 536f18c6e ("gradle plugin: implement get_build_properties() (#975)"), adding a get_build_properties() implementation plus tests (+18/-4, 3 files) and resolving Launchpad bug 1649988.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the maven.py plugin to use the get_build_properties() method instead of modifying the schema.
https://bugs.launchpad.net/snapcraft/+bug/1649988
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged as #975 (commit 536f18c6e), updating Gradle to use get_build_properties() instead of modifying the schema, fixing Launchpad bug 1649988. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following reviewer approval and passing CI. The update replaces direct schema modification in maven.py with the get_build_properties() method, resolving bug 1649988. The change modifies three files, adding 18 lines and removing 4. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged into master. Updated the maven.py plugin to use get_build_properties() instead of modifying the schema, resolving bug 1649988. Code coverage increased by 0.02%. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#974
(confidence 92%)
Sibling PR (commit 9a1482d41) applying the same get_build_properties() migration to the maven plugin; body references maven.py.
-
Related To:
snapcraft#979
(confidence 70%)
Same migration series for other plugins (waf, cmake, autotools, make, go, nodejs, ant, qmake, gulp, kernel, copy), fixing Launchpad bug 1650079 among others.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #999 Updated autotools plugin to use get_build_properties() | snapcraft | merged | Merged as commit 026fcfdf6: autotools plugin migrated to get_build_properties(), with schema unit test and get_pull_properties() tests updated. Resolves Launchpad bug #1650608. | |
| #978 Updated cmake plugin to use get_build_properties() | snapcraft | merged | Merged PR #978 updated the CMake plugin to implement get_build_properties(), addressing Launchpad bug #1650078 in commit 989177ee3. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #1649986 update maven plugin to use get_build_properties | snapcraft (launchpad) | closed | External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests. | |
| #991 Updated ant plugin to use get_build_properties() | snapcraft | merged | Merged PR #991 in commit 65efd4678, updating the Ant plugin to use get_build_properties() and register build-properties so warnings are emitted correctly. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| #979 Updated waf plugin to use get_build_properties() | snapcraft | merged | Merged as commit f8359e3cc, updating the Waf plugin to the new get_build_properties() API (part of a wider plugin migration, LP bug #1650079). | |
| #1022 plugins: update copy plugin to use get_build_properties(). | snapcraft | merged | Merged as commit e9e05f959: copy plugin migrated from deprecated properties to get_build_properties(), the final plugin in the LP #1647899 migration series. | |
| #994 Updated kbuild plugin to use get_build_properties() | snapcraft | closed | Superseded by #995, which merged the get_build_properties() update in commit fbd8887ac. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. |