← Back to issue list

update maven plugin to use get_build_properties

View original Launchpad issue

Metadata

Project
snapcraft (launchpad)
Number
#1649986
Type
issue
State
closed
Author
~matt-aguirre
Labels
—
Created
Updated
Closed

Current evaluation

External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests.

Resolution: closed resolved

Reason: The reporter linked snapcore/snapcraft#974, which was merged into snapcraft master as commit 9a1482d41 implementing get_build_properties() for the maven plugin with accompanying unit tests. The issue was then closed as fixed.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Updated the maven.py plugin to use the get_build_properties() method instead of modifying the schema.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests.
stealth/space-bunny-alpha — closed resolved External contribution from matt-aguirre landed as snapcore/snapcraft#974 (commit 9a1482d41, 'maven plugin: implement get_build_properties()'), replacing the maven plugin's schema modification with get_build_properties() plus tests.
stealth/space-bunny-alpha — closed resolved Merged canonical/snapcraft#974 (9a1482d41), replacing Maven plugin schema modification with get_build_properties() and adding tests.
qwen/qwen3.6-35b-a3b — — Resolved by updating the maven plugin to use get_build_properties() instead of modifying the schema. The issue was closed.
qwen/qwen3.6-35b-a3b — — The maven plugin was updated to use get_build_properties() instead of modifying the schema. The issue was closed after implementation.
qwen/qwen3.6-35b-a3b — — The maven plugin was updated to use get_build_properties() instead of schema modification. The issue was closed following implementation.
qwen3.6-35b-a3b-mtp-q6 — — The maven.py plugin was updated to use get_build_properties() instead of modifying the schema. The issue was closed after implementation.

Update history

Date Change
created

Related work

  • Likely Fixed By: canonical/snapcraft#974 (confidence 97%)

    Merged PR cited in the sole issue comment; commit 9a1482d41 touches snapcraft/plugins/maven.py and implements get_build_properties().

  • Related To: canonical/snapcraft#995 (confidence 55%)

    Part of the same 2.24-2.25 series converting plugins to get_build_properties() (kernel, make, autotools, ant, go, nodejs, qmake, gulp, copy, cmake, scons, waf).

Related issues

Issue Project State Summary Similarity
#974 Updated maven plugin to use get_build_properties() snapcraft merged Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986.
90%
#1650548 Update make plugin to use get_build_properties snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests.
82%
#1650078 Updated cmake plugin to use get_build_properties snapcraft (launchpad) closed CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3.
82%
#1650608 Update autotools plugin to use get_build_properties snapcraft (launchpad) closed Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6).
80%
#1650603 Update gulp plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests.
79%
#1650600 Update nodejs plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests.
79%
#1650553 Update qmake plugin to use get_build_properties snapcraft (launchpad) closed Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests.
79%
#1650547 Update ant plugin to use get_build_properties snapcraft (launchpad) closed Ant was updated to use get_build_properties() and register build properties for correct warnings; snapcore/snapcraft#991 merged as commit 65efd4678.
78%
#975 Updated gradle plugin to use get_build_properties() snapcraft merged External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series.
78%
#1650606 Updated go plugin to use get_build_properties() snapcraft (launchpad) closed Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage.
78%