← Back to issue list

Updated maven plugin to use get_build_properties()

View original Github issue

Metadata

Project
snapcraft
Number
#974
Type
pull request
State
merged
Author
ZenHarbinger
Labels
—
Created
Updated
Closed

Current evaluation

Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986.

Resolution: closed resolved

Reason: The PR was merged into master as commit 9a1482d41 ('maven plugin: implement get_build_properties() (#974)'), which appears in the history of snapcraft/plugins/maven.py. Maintainer review comments asked for unit tests to be added, which the contributor included in the merged diff (+17/-10 across plugin and tests), resolving the deprecated-schema-property breakage tracked in Launchpad bug #1649986.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Updated the maven.py plugin to use the get_build_properties() method instead of modifying the schema. https://bugs.launchpad.net/snapcraft/+bug/1649986

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986.
stealth/space-bunny-alpha — closed resolved Merged in snapcore/snapcraft#974 (commit 9a1482d41), updating the Maven plugin to use get_build_properties() and adding tests instead of modifying the schema.
qwen/qwen3.6-35b-a3b — — Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, resolving deprecated property checks. CI passed and coverage increased by 0.02%.
qwen3.6-35b-a3b-mtp-q6 — — Merged update to the maven plugin that replaces schema modification with get_build_properties(). Unit tests were added to verify the change, increasing coverage. CI flakiness was resolved prior to merge.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#975 (confidence 80%)

    Gradle plugin get_build_properties() (commit 536f18c6e), part of the same LP #1649986 series; also related to LP bug #1649988.

  • Caused By: snapcraft#923 (confidence 70%)

    'pluginhandler: source management moved to the core' (commit 4c35acef2) moved build-property handling out of the schema, which broke the maven plugin's schema patching.

  • Related To: snapcraft#2361 (confidence 65%)

    Later PR (commit b6be1d330) removing the deprecated plugin pull/build-properties keys entirely, completing this migration.

  • Related To: snapcraft#992 (confidence 55%)

    One of many sibling plugins (make, ant, autotools, cmake, waf, scons, qmake, go, nodejs, gulp, kernel, copy) migrated to get_build_properties() in the same effort.

Related issues

Issue Project State Summary Similarity
#1649986 update maven plugin to use get_build_properties snapcraft (launchpad) closed External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests.
90%
#1650078 Updated cmake plugin to use get_build_properties snapcraft (launchpad) closed CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3.
84%
#1650548 Update make plugin to use get_build_properties snapcraft (launchpad) closed Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests.
82%
#1650608 Update autotools plugin to use get_build_properties snapcraft (launchpad) closed Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6).
80%
#1650606 Updated go plugin to use get_build_properties() snapcraft (launchpad) closed Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage.
79%
#975 Updated gradle plugin to use get_build_properties() snapcraft merged External contributor PR merged as commit 536f18c6e, switching the Gradle plugin from schema mutation to get_build_properties(); closes Launchpad bug 1649988. Part of a wider plugin cleanup series.
78%
#1650600 Update nodejs plugin to use get_build_properties and get_pull_properties snapcraft (launchpad) closed Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests.
78%
#1650547 Update ant plugin to use get_build_properties snapcraft (launchpad) closed Ant was updated to use get_build_properties() and register build properties for correct warnings; snapcore/snapcraft#991 merged as commit 65efd4678.
77%
#1649988 update gradle plugin to use get_build_properties snapcraft (launchpad) closed Launchpad bug #1649988 reported by ~matt-aguirre was fixed by snapcraft PR #975 (commit 536f18c6e, "gradle plugin: implement get_build_properties()"), merged into master; the demo snapcraft.yaml was also set to grade: stable. Bug closed as fixed.
76%
#996 Updated nodejs plugin to use get_build_properties() snapcraft merged Merged PR #996 updated Snapcraft's Node.js plugin to use get_build_properties()/get_pull_properties() and refreshed schema tests; landed as 2f0be3554.
76%