Update make plugin to use get_build_properties
Metadata
Current evaluation
Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests.
Resolution: closed resolved
Reason: The maintainer linked snapcore/snapcraft#992 as the resolution, and that PR merged into snapcraft master as commit 65a1dd09c, converting parts/plugins/make.py to implement get_build_properties() and adding coverage in test_plugin_make.py. It was one of a series of plugin migrations tracked under the umbrella Launchpad bug #1647899.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the make.py plugin to use the get_build_properties() method instead of modifying the schema.
Updated the test_plugin_make.py file to add test.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR snapcore/snapcraft#992 in commit 65a1dd09c, replacing Make schema mutation with get_build_properties() and adding tests; it resolved Launchpad bug #1650548. | |
| stealth/space-bunny-alpha | — | closed stale | The proposed make.py migration to get_build_properties() was closed without a documented resolution or identifiable fixing PR. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed after implementation. Updated make.py to use get_build_properties() instead of schema modification and added corresponding tests. | |
| qwen/qwen3.6-35b-a3b | — | — | The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The issue was closed after implementation. | |
| qwen/qwen3.6-35b-a3b | — | — | The make plugin was updated to use get_build_properties() instead of schema modification, with tests added to test_plugin_make.py. Changes were merged and the item closed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | The make plugin was updated to use get_build_properties() instead of schema modification, with tests added. The change was implemented and the issue closed. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcore/snapcraft#992
(confidence 99%)
Merged PR cited by the author in the sole issue comment; landed as commit 65a1dd09c 'plugins: update make plugin to use get_build_properties()'.
-
Related To:
snapcraft (launchpad)#1647899
(confidence 80%)
Umbrella Launchpad bug covering the broader plugin migration to get_build_properties(), of which this item is one part.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1650608 Update autotools plugin to use get_build_properties | snapcraft (launchpad) | closed | Autotools plugin was updated to use get_build_properties() instead of mutating the schema, with tests, in merged PR snapcore/snapcraft#999 (commit 026fcfdf6). | |
| #1650553 Update qmake plugin to use get_build_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft PR #993 (commit 2171f6367), updating qmake to use get_build_properties() and get_pull_properties() and adding tests. | |
| #992 plugins: update make plugin to use get_build_properties() | snapcraft | merged | Merged #992, updating the make plugin and its tests to use get_build_properties(); landed as commit 65a1dd09c. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. | |
| #1650078 Updated cmake plugin to use get_build_properties | snapcraft (launchpad) | closed | CMake plugin adopted get_build_properties() instead of modifying the schema; merged in snapcore/snapcraft#978 at commit 989177ee3. | |
| #974 Updated maven plugin to use get_build_properties() | snapcraft | merged | Merged into snapcraft master as commit 9a1482d41: the Maven plugin now implements get_build_properties() (plus unit tests) instead of injecting build attrs into the schema, fixing LP bug #1649986. | |
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage. | |
| #1649986 update maven plugin to use get_build_properties | snapcraft (launchpad) | closed | External contribution from matt-aguirre merged as snapcore/snapcraft#974 (commit 9a1482d41, "maven plugin: implement get_build_properties()"), replacing the maven plugin's schema modification with get_build_properties() plus unit tests. | |
| #1650597 Update kernel plugin to use get_build_properties | snapcraft (launchpad) | closed | Kernel plugin migration merged in commit fbd8887ac via snapcore/snapcraft#995, replacing schema mutation with get_build_properties() and adding tests. | |
| #1650603 Update gulp plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests. |