Update godeps plugin to use get_pull_properties
Metadata
Current evaluation
Godeps was refactored to use get_pull_properties() with updated tests; merged via snapcore/snapcraft#1000 at commit 9b8303005.
Resolution: closed resolved
Reason: Merged PR snapcore/snapcraft#1000 resolved the Launchpad item. Commit 9b8303005 records the godeps plugin change and associated test updates.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Updated the godeps.py plugin to use the and get_pull_properties() methods instead of modifying the schema.
Updated the test_plugin_godeps.py file to add test.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Godeps was refactored to use get_pull_properties() with updated tests; merged via snapcore/snapcraft#1000 at commit 9b8303005. | |
| stealth/space-bunny-alpha | — | closed resolved | External contributor refactored the godeps plugin to use get_pull_properties() instead of mutating its schema, plus tests. Merged into snapcraft main as commit 9b8303005 via snapcore/snapcraft#1000 (Launchpad bug #1650624). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in snapcraft PR #1000 as 9b8303005: updated the godeps plugin to use get_pull_properties() instead of modifying its schema, with tests added. | |
| qwen/qwen3.6-35b-a3b | — | — | Updated the godeps plugin to use get_pull_properties() instead of modifying the schema, with corresponding tests added. The changes were merged and the issue closed. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed without implementation. The proposed refactoring to use get_pull_properties() instead of schema modification, along with new tests, was not merged or addressed. | |
| qwen/qwen3.6-35b-a3b | — | — | Resolved by updating the godeps plugin to use get_pull_properties() instead of modifying the schema. Tests were added to verify the changes. The implementation was applied and the ticket closed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Proposed changes to replace schema modifications with get_pull_properties() in the godeps plugin were abandoned. The issue closed without merging the code or tests. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Likely Fixed By:
snapcore/snapcraft#1000
(confidence 100%)
Merged PR implementing the requested get_pull_properties() refactor.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1000 Updated godeps plugin to use get_pull_properties() | snapcraft | merged | Merged PR #1000 in commit 9b8303005, updating the godeps plugin to use get_pull_properties() and adding schema and unit tests. | |
| #1794784 Update the godeps plugin to be base aware | snapcraft (launchpad) | closed | Godeps gained base support through snapcore/snapcraft PR #2328, implemented by commit e1393815d. | |
| #691 Add godeps plugin. | snapcraft | merged | Godeps plugin merged into snapcraft via commit a073503c0 (PR #691), adding Go godeps dependency support and resolving LP bug #1595981; later enhanced by follow-up PRs. | |
| #1650626 Update python plugin to use get_pull_properties | snapcraft (launchpad) | closed | Updated the Python plugin to use get_pull_properties() instead of modifying the schema, with tests, in snapcore/snapcraft PR #1002; merged as dc26a14b2. | |
| #1595981 Need a godeps plugin | snapcraft (launchpad) | closed | Godeps plugin support was merged in snapcore/snapcraft#691 via commit a073503c0. | |
| #1650606 Updated go plugin to use get_build_properties() | snapcraft (launchpad) | closed | Go plugin build-property handling was fixed by merged snapcore/snapcraft PR #997 in commit 0b4239ce7, with added test coverage. | |
| #1650600 Update nodejs plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged in snapcore/snapcraft#996 (commit 2f0be3554), updating the Node.js plugin to use get_build_properties()/get_pull_properties() instead of modifying the schema, with tests. | |
| #1650603 Update gulp plugin to use get_build_properties and get_pull_properties | snapcraft (launchpad) | closed | Merged snapcore/snapcraft#998 as acf95e174, updating gulp to use get_build_properties() and get_pull_properties() and adding unit and schema tests. | |
| #1922150 godeps using seemingly invalid commit hash | snapcraft (launchpad) | closed | Fixed by merged snapcore/snapcraft#3475 (commit a6dfe1cd2), which defaulted the unmaintained godeps plugin to Go 1.15/stable; the reporter confirmed the workaround restored CI. | |
| #1650548 Update make plugin to use get_build_properties | snapcraft (launchpad) | closed | Fixed by merged PR snapcore/snapcraft#992 (commit 65a1dd09c, 'plugins: update make plugin to use get_build_properties()'): the make plugin no longer mutates schema values and instead returns them via get_build_properties(), with new unit tests. |