autotools: extend Make plugin instead of repeating code
Metadata
Current evaluation
Closed after inactivity; the same Autotools-to-Make plugin refactor was re-proposed in snapcraft#1076 and merged as commit 83072a5b2.
Resolution: closed superseded
Reason: Maintainer kyrofa closed the stalled PR and requested a fresh proposal. snapcraft#1076 superseded it and merged the refactor in commit 83072a5b2.
Evaluated by: mr-cal-bot
No scores available.
Issue body
We can use the self.make function from make instead of redefining the build process again here.
[LP: #1659363](https://pad.lv/1659363)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Closed after inactivity; the same Autotools-to-Make plugin refactor was re-proposed in snapcraft#1076 and merged as commit 83072a5b2. | |
| stealth/space-bunny-alpha | — | closed superseded | Closed as inactive; the same autotools/Make-plugin refactor was later merged in #1076 as commit 83072a5b2. | |
| qwen/qwen3.6-35b-a3b | — | — | Closed due to inactivity after a reviewer requested a bug report and changes. The author responded and added the bug, but a force-push prevented reopening. The reviewer instructed the author to re-propose the pull request. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Closed due to inactivity. The maintainer requested a new pull request after GitHub prevented reopening following a force-push. The changes were not merged. |
Update history
No update history recorded yet.
Related work
-
Superseded By:
canonical/snapcraft#1076
(confidence 100%)
Re-proposed and merged the Autotools plugin change to extend and reuse the Make plugin.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1076 autotools: extend Make plugin instead of repeating code | snapcraft | merged | Merged into master: Autotools was changed to extend the Make plugin and reuse its build flow instead of duplicating logic (commit 83072a5b2). | |
| #1659363 Autotools plugin should inherit make | snapcraft (launchpad) | closed | Superseded by canonical/snapcraft#1076, which merged the Autotools-to-Make plugin refactor in commit 83072a5b2 after #1018 became inactive. | |
| #1536700 autotools plugin doesn't call make | snapcraft (launchpad) | closed | autotools plugin skipped the build step, running only `make install`. Fixed by canonical/snapcraft PR #253 ("Autotools plugin: Call make before make install"), merged as commit e09cdb58b. | |
| #1794777 Update the autotools plugin to be base aware | snapcraft (launchpad) | closed | Autotools became base-aware through merged snapcraft#2363, commit 2f3879d93, adding core16/core18 support for Make, CMake, and Autotools plugins. | |
| #3694 autotools v1 plugin: fix fatal crash when running autogen.sh or bootstrap | snapcraft | closed | Closed unmerged as superseded by snapcraft#3739, which merged the broader legacy-plugin Path-to-string fix in commit e4725e466. | |
| #35 plugins: add autotools plugin | craft-parts | merged | Merged PR #35, adding an Autotools plugin for parts built through the ./configure script; implementation 54b124c8, merge commit 6140b8e6. | |
| #254 Backport to 1.x: Autotools plugin: Call make before make install | snapcraft | merged | Merged snapcraft#254 into 1.x, backporting #253 so the Autotools plugin runs make before make install. | |
| #783 Add an integration test for autotools | snapcraft | merged | Merged snapcraft#783 in commit 874b28041, adding integration-test coverage for the Autotools plugin and resolving LP bug #1621694. | |
| #1783825 Move Autotools plugin tests to spread | snapcraft (launchpad) | closed | Autotools and snapd plugin integration tests were consolidated into a Spread suite by merged PR #2182 (commit eadd86729), resolving LP #1783825. | |
| #1621694 autotools plugin has no integration tests | snapcraft (launchpad) | closed | Added autotools plugin integration-test coverage; snapcore/snapcraft#783 was merged as commit 874b28041, resolving the missing-test issue. |