← Back to issue list

autotools: extend Make plugin instead of repeating code

View original Github issue

Metadata

Project
snapcraft
Number
#1018
Type
pull request
State
closed
Author
3v1n0
Labels
Created
Updated
Closed

Current evaluation

Closed due to inactivity after a reviewer requested a bug report and changes. The author responded and added the bug, but a force-push prevented reopening. The reviewer instructed the author to re-propose the pull request.

Suggested action:

No scores available.

Issue body

We can use the self.make function from make instead of redefining the build process again here. [LP: #1659363](https://pad.lv/1659363)

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Closed due to inactivity after a reviewer requested a bug report and changes. The author responded and added the bug, but a force-push prevented reopening. The reviewer instructed the author to re-propose the pull request.
qwen3.6-35b-a3b-mtp-q6 Closed due to inactivity. The maintainer requested a new pull request after GitHub prevented reopening following a force-push. The changes were not merged.
qwen3.6-35b-a3b-mtp-q6 Closed due to inactivity after a bug report was requested. The contributor added the report and asked to reopen, but a force-push prevented it. Maintainers advised re-proposing the pull request.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1076 autotools: extend Make plugin instead of repeating code snapcraft merged Merged into master. Refactored the autotools plugin to extend the existing Make plugin, eliminating duplicated build logic. Approved by one reviewer, passed CI checks, and reduced code by 19 lines across four files.
81%
#3694 autotools v1 plugin: fix fatal crash when running autogen.sh or bootstrap snapcraft closed Superseded by pull request #3739. The autotools v1 plugin crash fix was closed without merging after three weeks of review inactivity.
74%
#1536700 autotools plugin doesn't call make snapcraft (launchpad) closed Closed without discussion, likely abandoned. The autotools plugin was reported to skip the make step before make install, causing build failures for some projects.
72%
#1659363 Autotools plugin should inherit make snapcraft (launchpad) closed The suggestion to refactor the autotools plugin to inherit from make was closed without discussion or implementation, indicating the request was abandoned.
72%
#1794777 Update the autotools plugin to be base aware snapcraft (launchpad) closed Closed. The request to update the autotools plugin for base awareness was abandoned without further discussion, comments, or a linked merge.
70%