Autotools plugin should inherit make
Metadata
Current evaluation
Superseded by canonical/snapcraft#1076, which merged the Autotools-to-Make plugin refactor in commit 83072a5b2 after #1018 became inactive.
Resolution: closed superseded
Reason: The original implementation in canonical/snapcraft#1018 became inactive. The same refactor was re-proposed as canonical/snapcraft#1076 and merged in commit 83072a5b2, making Autotools extend and reuse the Make plugin.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Since autotools uses make, it's reasonable to rebase autotools on it, so that we can manage all the make options at just one level.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed superseded | Superseded by canonical/snapcraft#1076, which merged the Autotools-to-Make plugin refactor in commit 83072a5b2 after #1018 became inactive. | |
| stealth/space-bunny-alpha | — | closed superseded | Superseded by snapcore/snapcraft#1076, which merged the Autotools/Make refactor in commit 83072a5b2 after #1018 became inactive. | |
| stealth/space-bunny-alpha | — | closed resolved | Autotools was rebased on the Make plugin, centralizing make options; PR #1076 was merged as commit 83072a5b2. | |
| qwen/qwen3.6-35b-a3b | — | — | The suggestion to refactor the autotools plugin to inherit from make was closed without discussion or implementation, indicating the request was abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | Proposal to rebase the autotools plugin on the make plugin for centralized option management was closed without implementation or discussion. The suggestion was abandoned. | |
| qwen/qwen3.6-35b-a3b | — | — | The proposal to rebase the Autotools plugin on Make was closed without discussion or implementation. The suggestion was abandoned with no changes made. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | The autotools plugin inheritance proposal was closed without discussion or implementation, indicating it was abandoned. |
Update history
| Date | Change |
|---|---|
| created |
Related work
-
Superseded By:
canonical/snapcraft#1076
(confidence 100%)
Merged replacement for the inactive PR #1018, resolving the plugin inheritance request.
-
Related To:
canonical/snapcraft#1018
(confidence 100%)
Original proposed implementation linked from the issue; closed after inactivity.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1018 autotools: extend Make plugin instead of repeating code | snapcraft | closed | Closed after inactivity; the same Autotools-to-Make plugin refactor was re-proposed in snapcraft#1076 and merged as commit 83072a5b2. | |
| #1076 autotools: extend Make plugin instead of repeating code | snapcraft | merged | Merged into master: Autotools was changed to extend the Make plugin and reuse its build flow instead of duplicating logic (commit 83072a5b2). | |
| #1794777 Update the autotools plugin to be base aware | snapcraft (launchpad) | closed | Autotools became base-aware through merged snapcraft#2363, commit 2f3879d93, adding core16/core18 support for Make, CMake, and Autotools plugins. | |
| #1536700 autotools plugin doesn't call make | snapcraft (launchpad) | closed | autotools plugin skipped the build step, running only `make install`. Fixed by canonical/snapcraft PR #253 ("Autotools plugin: Call make before make install"), merged as commit e09cdb58b. | |
| #1794792 Update the make plugin to be base aware | snapcraft (launchpad) | closed | Make plugin made base aware by merged snapcore/snapcraft#2363 (commit 2f3879d93), adding core16/core18 support for the make, cmake and autotools plugins; bug closed as fixed. | |
| #3694 autotools v1 plugin: fix fatal crash when running autogen.sh or bootstrap | snapcraft | closed | Closed unmerged as superseded by snapcraft#3739, which merged the broader legacy-plugin Path-to-string fix in commit e4725e466. | |
| #254 Backport to 1.x: Autotools plugin: Call make before make install | snapcraft | merged | Merged snapcraft#254 into 1.x, backporting #253 so the Autotools plugin runs make before make install. |