tests: add spread tests for validation-sets
Metadata
Current evaluation
Merged PR #4924 added spread coverage for edit-validation-sets and list-validation-sets, closing #4918; merge commit 157d0a182.
Resolution: closed resolved
Reason: PR #4924 was approved and merged, adding the missing validation-set command tests in commit 157d0a182. Its body explicitly states “Fixes #4918,” and that issue is now closed.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Adds a spread test for `edit-validation-sets` and `list-validation-sets`.
I need help from @sergiusens to set up a key for the `sergio.schvezov+snapcraft-test@canonical.com` account:
1. Create and register a key with the staging store.
2. Add the private key as a Github secret called `SNAPCRAFT_ASSERTION_KEY`
- The secret can be generated with `gpg --homedir ~/.snap/gnupg/ --armor --export-secret-keys testspreadkey | base64 | tr -d "\n"`
Fixes #4918
(CRAFT-3117)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4924 added spread coverage for edit-validation-sets and list-validation-sets, closing #4918; merge commit 157d0a182. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4924 (commit 157d0a182), adding spread coverage for edit-validation-sets and list-validation-sets and fixing #4918. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4924 (commit 157d0a182) added spread tests for edit-validation-sets and list-validation-sets in tests/spread/store/validation-sets/task.yaml, closing issue #4918 (CRAFT-3117). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4924 (commit 157d0a182) added spread tests for edit-validation-sets and list-validation-sets, resolving #4918. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4924 added spread coverage for edit-validation-sets and list-validation-sets, resolving #4918. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes adding spread tests for edit-validation-sets and list-validation-sets. Approved by two reviewers with passing CI, resolving issue #4918. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds spread tests for edit-validation-sets and list-validation-sets commands. Resolves #4918. Requires a manually configured GPG assertion key secret for test execution. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#4918
(confidence 100%)
PR #4924 explicitly fixes the request for validation-set command tests in issue #4918.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4918 Test validation-set commands | snapcraft | closed | Added and merged spread tests for edit-validation-sets and list-validation-sets in PR #4924 (commit 157d0a182), resolving #4918. | |
| #5075 tests: fix validation sets spread test | snapcraft | merged | Merged PR #5075 (commit a22b218ab) fixed #5053 by making the validation-sets spread test use hello-world and check presence instead of a fixed revision. | |
| #5091 tests: add spread tests for registries | snapcraft | merged | Merged in commit b746c6c8c via #5091, adding spread tests for edit-registries and list-registries and fixing #5054. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%. | |
| #5053 Fix validation-sets spread test | snapcraft | closed | Fixed validation-sets spread-test coverage in commit a22b218ab after staging-store cleanup removed the required test snap. | |
| #16 tests: add spread support | rockcraft | merged | Merged PR #16 added Spread support for CRAFT-865 via commit 3aeba2b3 (merge commit 5bf2680a). | |
| #2210 tests: add spread suite for waf plugin | snapcraft | merged | Merged PR #2210 moved Waf plugin integration tests into a new Spread suite, resolving LP #1783846 in commit 5498d0aba. | |
| #3662 tests: update spread url | snapcraft | merged | Merged PR #3662 updated Spread tarball URLs in two test files via commit 507959d70. | |
| #1266 tests(spread): requirements dependencies | charmcraft | merged | Merged PR #1266 at 97d95b39, adding spread tests for requirements-file and charm-dependency combinations; the PR explicitly fixes #1179. | |
| #4433 tests(spread): add remote-build spread test | snapcraft | merged | Merged #4433 (commit 4a0a91117), adding weekly spread coverage for new and legacy remote-build implementations and resolving #4398. |