tests: add spread tests for validation-sets
Metadata
Current evaluation
Merged changes adding spread tests for edit-validation-sets and list-validation-sets. Approved by two reviewers with passing CI, resolving issue #4918.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Adds a spread test for `edit-validation-sets` and `list-validation-sets`.
I need help from @sergiusens to set up a key for the `sergio.schvezov+snapcraft-test@canonical.com` account:
1. Create and register a key with the staging store.
2. Add the private key as a Github secret called `SNAPCRAFT_ASSERTION_KEY`
- The secret can be generated with `gpg --homedir ~/.snap/gnupg/ --armor --export-secret-keys testspreadkey | base64 | tr -d "\n"`
Fixes #4918
(CRAFT-3117)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes adding spread tests for edit-validation-sets and list-validation-sets. Approved by two reviewers with passing CI, resolving issue #4918. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Adds spread tests for edit-validation-sets and list-validation-sets commands. Resolves #4918. Requires a manually configured GPG assertion key secret for test execution. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to implement spread tests for edit-validation-sets and list-validation-sets, resolving issue #4918. Test coverage for validation set commands is now included, with GPG key setup required for the test account. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #127 Fix spread tests | imagecraft | merged | Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines). | |
| #534 test(spread): workaround for flaky test | fetch-service | merged | Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks. | |
| #5075 tests: fix validation sets spread test | snapcraft | merged | Merged fix for validation sets spread test switching to the hello-world snap and flipping the presence check instead of a specific revision. Approved by two reviewers with passing CI, resolving issue #5053. | |
| #4433 tests(spread): add remote-build spread test | snapcraft | merged | Merged changes adding spread tests for new and legacy remote-build, resolving issue #4398. Approved by two reviewers with passing CI checks. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration. | |
| #5091 tests: add spread tests for registries | snapcraft | merged | Added spread tests for edit-registries and list-registries, resolving issue #5054. Merged following approval by two reviewers. Minor unrelated network failures were noted but did not block the merge. | |
| #3662 tests: update spread url | snapcraft | merged | Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage. | |
| #16 tests: add spread support | rockcraft | merged | Merged after approval and passing CI, adding spread support to tests per CRAFT-865. | |
| #62 spread: add a "big" spread test | rockcraft | merged | Merged a reusable spread test framework to house multiple checks without repeated setup. The initial test validates bug #44 regarding directory permissions. Approved by one reviewer and passed CI checks. | |
| #1705 test: extend timeout for some spread tests | charmcraft | merged | Merged changes extending timeouts for specific spread tests to prevent failures from lengthy preparation steps. Approved by reviewers, passed CI, and modified two files. |