Catkin plugin: Support ROS Kinetic.
Metadata
Current evaluation
Merged as commit 5d447aedc, adding ROS Kinetic support to the catkin plugin by refactoring repository source handling into an overridable function and adding a ROS-release-to-Ubuntu-release map (fixes LP #1629003).
Resolution: closed resolved
Reason: PR #842 was approved and merged by maintainer kyrofa as commit 5d447aedc (visible in snapcraft/plugins/catkin.py history). It resolves LP bug #1629003; review also uncovered a fileutils coverage gap which the author fixed in-PR before merge.
Evaluated by: mr-cal-bot
No scores available.
Issue body
Resolve LP: [#1629003](https://bugs.launchpad.net/snapcraft/+bug/1629003) by refactoring the repository source handling into a function that could be re-implemented by subclasses, as well as adding a map of ROS releases to Ubuntu releases. Should make it easy to support newer ROS releases, too.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 5d447aedc, adding ROS Kinetic support to the catkin plugin by refactoring repository source handling into an overridable function and adding a ROS-release-to-Ubuntu-release map (fixes LP #1629003). | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #842 as commit 5d447aedc, adding ROS Kinetic support through extensible Catkin source handling and ROS/Ubuntu release mapping; review also fixed a fileutils coverage gap. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged. Adds ROS Kinetic support to the Catkin plugin by refactoring source handling for extensibility and mapping ROS to Ubuntu releases. Fixed a fileutils coverage gap during review. Approved and merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to add ROS Kinetic support by refactoring repository source handling into a reusable function and mapping ROS releases to Ubuntu versions. A minor fileutils coverage gap was identified and resolved during review prior to merge. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#850
(confidence 60%)
Follow-up PR adding rosdistro documentation for the same plugin shortly after Kinetic support
-
Related To:
snapcraft#851
(confidence 55%)
Follow-up PR handling invalid rosdistro, a consequence of the new ROS-release map introduced here
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1629003 Catkin plugin: support kinetic | snapcraft (launchpad) | closed | ROS Kinetic support was added to the Catkin plugin by snapcore/snapcraft PR #842, merged as commit 5d447aedc; the maintainer closed the issue pointing to that fix. | |
| #152 Catkin plugin: Add support for ROS tools. | snapcraft | merged | Merged #152 as fc5142126, adding ROS package installation, roslaunch/rosrun support, updated examples, and doubled Catkin test coverage. | |
| #1367 catkin plugin: add support for ROS Lunar | snapcraft | merged | Merged PR #1367 (commit ba722e847), adding ROS Lunar support and the lsb-release build workaround for Launchpad bug #1677002. | |
| #1533735 Catkin plugin: Support rosinstall files | snapcraft (launchpad) | closed | Catkin rosinstall support was merged in PR #1314 (commit 97a416d0a); rosinstall-files was later corrected to a pull property in #1473. | |
| #1314 catkin plugin: add support for rosinstall files | snapcraft | merged | Merged PR #1314 as commit 97a416d0a, adding ordered multi-file rosinstall support to the Catkin plugin and resolving Launchpad #1533735. | |
| #1548404 Catkin plugin: Can't handle rosdep resolving to multiple packages | snapcraft (launchpad) | closed | Fixed by ubuntu-core/snapcraft PR #331 (commit 1c1119ce3, 'Catkin plugin: Handle rosdep empty and multiple dependencies'), merged as e3a2b9d03; maintainer ~kyrofa linked the PR when closing the Launchpad bug. | |
| #1830769 Catkin plugin: tests failing due to indigo EOL | snapcraft (launchpad) | closed | Catkin spread tests were moved from EOL ROS Indigo to Kinetic by merged PR canonical/snapcraft#2575 (commit 2c1b97bf4); PR #2572 handled the release branch. | |
| #1581 catkin plugin: support rosdep pip dependencies | snapcraft | merged | Merged PR #1581 in commit 186ae7f91, adding pip-based rosdep dependency support to the Catkin plugin and fixing LP bug #1683036. | |
| #180 Backport to 1.x: Catkin plugin: Add support for ROS tools. | snapcraft | merged | Merged #180, backporting #152 to the 1.x branch to add ROS tools support to the Catkin plugin. | |
| #2333 catkin, catkin-tools: add support for bases | snapcraft | merged | Merged PR #2333 via commit a7fb1b137, adding base-aware catkin support: core16 selects Kinetic, core18 selects Melodic, and rosdistro is removed. |