← Back to issue list

build providers: remove the qemu implementation

View original Github issue

Metadata

Project
snapcraft
Number
#2345
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged the removal of the QEMU build provider implementation, superseded by multipass. The change deleted 1062 lines across 12 files after approval and passing CI checks.

Suggested action:

No scores available.

Issue body

The qemu implementation of the build provider has fallen out of favour to multipass. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged the removal of the QEMU build provider implementation, superseded by multipass. The change deleted 1062 lines across 12 files after approval and passing CI checks.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the QEMU build provider implementation, as Multipass became the preferred alternative. The change was integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 Merged removal of the qemu build provider implementation, superseded by multipass. Integrated into the main branch without coverage blockers.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#2447 build providers: remove SIGUSR1 signal ignore workaround for multipass snapcraft merged Merged removal of the SIGUSR1 signal ignore workaround for multipass following an upstream fix. The change deletes 11 lines of code, passed CI checks, and received reviewer approval.
76%
#2869 build providers: use multipass from stable snapcraft merged Merged update to consume Multipass 1.0 from the stable channel for build providers. Approved by one reviewer, modifying four files with minimal changes.
75%
#2474 build providers: remove dead code snapcraft merged Merged removal of dead code for legacy cleanbuild support in build providers. Approved by one reviewer, passed CI, and modified three files (+54/-165 lines).
74%
#2961 build providers: remove over use of -i in sudo snapcraft merged Merged changes removing unnecessary -i flags from sudo commands in build providers. This resolves an ioctl warning in Multipass when stdin is set to DEVNULL. Approved by one reviewer, passed CI, and modified four files.
72%
#2168 build_providers: add ssh key managemet to the qemu build provider snapcraft merged Merged after approval, adding SSH key management to the QEMU build provider. Passed CI checks with 100% diff coverage. The change modifies four files, adding 154 lines to resolve Launchpad bug #1774013.
71%
#2511 build providers: modify the _run signature snapcraft merged Merged changes modifying the _run signature in build providers to return output. Updates the Multipass implementation to wrap execute calls. Approved by reviewer and passed CI checks.
70%