← Back to issue list

maven plugin: add support for bases

View original Github issue

Metadata

Project
snapcraft
Number
#2364
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

PR snapcraft#2364 merged as commit b4aebc678, making the Maven plugin base-aware with support for core16 and core18, resolving Launchpad bug #1794793 (18 files, +778/-345).

Resolution: closed resolved

Reason: The pull request was approved and merged into master as commit b4aebc678 ('maven plugin: add support for bases (#2364)'), confirmed in the commit history for snapcraft/plugins/maven.py. It implements the fix tracked by Launchpad bug #1794793.

Evaluated by: mr-cal-bot

No scores available.

Issue body

Update the Maven plugin to be base-aware, only supporting core16 and core18. LP: #1794793 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [ ] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved PR snapcraft#2364 merged as commit b4aebc678, making the Maven plugin base-aware with support for core16 and core18, resolving Launchpad bug #1794793 (18 files, +778/-345).
stealth/space-bunny-alpha — closed resolved Merged #2364 as b4aebc678, making the Maven plugin base-aware with core16 and core18 support and addressing Launchpad #1794793.
qwen/qwen3.6-35b-a3b — — Added base awareness to the Maven plugin, supporting core16 and core18. Merged after reviewer approval and CI checks, resolving Launchpad issue #1794793. Changes modify 18 files with 778 additions and 345 deletions.
qwen3.6-35b-a3b-mtp-q6 — — Merged. Updates the Maven plugin to be base-aware, adding support for core16 and core18. Resolves Launchpad issue #1794793. Changes achieved 80.89% diff coverage prior to integration.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: snapcraft (launchpad)#1794793 (confidence 92%)

    Launchpad bug 'Update the maven plugin to be base aware' cited in the PR body; closed by this merge.

  • Related To: canonical/snapcraft#2370 (confidence 80%)

    Companion PR making the ant plugin base-aware (commit eab7fcf15), merged in the same series.

  • Related To: canonical/snapcraft#2372 (confidence 80%)

    Companion PR making the gradle plugin base-aware, same base16/core18 scope.

  • Related To: canonical/snapcraft#2453 (confidence 65%)

    Later fix (41facca0a) correcting JRE defaults/path handling for core18 in the ant, maven and gradle plugins, indicating follow-up issues after this change.

Related issues

Issue Project State Summary Similarity
#2370 ant plugin: add support for bases snapcraft merged Merged via commit eab7fcf15: made the ant plugin base-aware, supporting only core16 and core18, and updated its tests/spread coverage. Closes Launchpad bug #1794776.
81%
#2372 gradle plugin: add support for bases snapcraft merged Merged in snapcraft#2372 (58bbbda02), making the Gradle plugin base-aware with support limited to core16 and core18.
81%
#1794793 Update the maven plugin to be base aware snapcraft (launchpad) closed Maven plugin support for bases was merged in snapcraft#2364, commit b4aebc678.
80%
#2366 qmake plugin: add support for bases snapcraft merged Merged in snapcraft PR #2366 as commit 3585eb13d, making the qmake plugin base-aware for core16/core18 and adding spread tests; resolves Launchpad bug #1794799.
79%
#2362 python plugin: add support for bases snapcraft merged Merged in snapcraft#2362 via commit 669eebe19, making the Python plugin base-aware for core16/core18 and moving its tests to spread.
78%
#1813637 maven plugin crashes with base core18 snapcraft (launchpad) closed Fixed by snapcore/snapcraft#2453, merged as commit 41facca0a, correcting JRE defaults for Ant, Maven, and Gradle plugins.
77%
#2373 rust plugin: add support for bases snapcraft merged Merged PR #2373 in commit eafd6d641, making the Rust plugin base-aware for core16 and core18 and resolving LP #1798681.
76%
#1794786 Update the gradle plugin to be base aware snapcraft (launchpad) closed Closed as done: merged snapcraft#2372 (commit 58bbbda02, "gradle plugin: add support for bases") made the Gradle plugin base-aware for core16/core18, tracked under the 18.10-build-vm milestone.
76%
#4657 feat(core22): maven plugin snapcraft merged Merged core22 Maven plugin support into Snapcraft through PR #4657, resolving in commit 952ecb172 after approval from three reviewers.
75%
#2368 {kbuild,kernel} plugin: add support for bases snapcraft merged Merged #2368 as ddbda36b5, adding core16/core18 base support to the KBuild and inherited Kernel plugins and resolving LP bugs #1794790/#1794791.
73%