← Back to issue list

mypy: add coverage to tests

View original Github issue

Metadata

Project
snapcraft
Number
#2738
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged changes adding mypy static type checking to unit tests. Updated mypy.ini to target Python 3.6 and applied minor test fixups for successful execution. Approved by one reviewer and merged with 12 additions and 11 deletions across seven files.

Suggested action:

No scores available.

Issue body

mypy.ini: set python version to 3.6 tests: minor fixups for mypy to run successfully runtests: add mypy coverage of unit tests for static target

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes adding mypy static type checking to unit tests. Updated mypy.ini to target Python 3.6 and applied minor test fixups for successful execution. Approved by one reviewer and merged with 12 additions and 11 deletions across seven files.
qwen3.6-35b-a3b-mtp-q6 Merged updates adding mypy static type checking to unit tests. Configured mypy.ini for Python 3.6 and applied minor test fixups to ensure successful execution.
qwen3.6-35b-a3b-mtp-q6 Merged. Integrated mypy static type checking into the test suite by configuring mypy.ini for Python 3.6 and applying minor test adjustments to resolve type errors.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#856 style: update mypy and fix linting issues craft-application merged Merged after receiving approval from two reviewers and passing all CI checks. The update refreshed mypy and resolved linting issues across two files, resulting in 38 additions and 32 deletions.
75%
#6 tools: Configure mypy starbase merged Configuring mypy was approved by one reviewer and successfully merged. The update modified two files, adding 30 lines and removing 1, to establish type checking in the project tools.
74%
#94 lint: fix mypy config to 'recurse' starbase merged Merged into main after approval. Fixed mypy configuration to recursively check sub-packages and modules. Passed CI with no coverage changes.
73%
#958 build(deps): update dependency mypy to ~=1.14.1 craft-parts merged Merged automated dependency update raising mypy from ~=1.11.0 to ~=1.14.1. Approved by two reviewers, passed CI checks, and applied to two files with 34 additions and 25 deletions.
73%
#1747 static tests: enable type checking by use of mypy snapcraft merged Merged after two approvals and passing CI. Enabled mypy type checking for static tests by resolving initial type errors and removing dead storeapi compat code. Integrated into runtests.sh static, deferring unit package init typing as a TODO.
72%
#215 style: drop mypy, pyright craft-grammar merged Merged a pull request replacing mypy and pyright with the ty type checker. After passing all CI checks and receiving two approvals, the change was successfully integrated, removing 481 lines of configuration across six files.
71%
#990 build(deps): update dependency mypy to ~=1.18.2 (main) rockcraft merged Merged automated dependency update upgrading mypy from 1.17.1 to 1.18.2. Approved by two reviewers with all CI checks passing. Two files were modified to update the static type checker to the latest stable release.
71%
#6034 style: fix mypy warnings snapcraft merged Merged after approval from two reviewers. The changes resolve two mypy type-checking warnings by modifying a single file. All CI checks passed, and the fix was integrated into the main branch.
71%
#479 style: drop mypy, pyright craft-cli merged Merged after approval from two reviewers; replaces mypy and pyright with ty, passing all CI checks. The change removed 341 lines and added 17 across 8 files.
71%