← Back to issue list

spread tests: add core20 and cleanup systems

View original Github issue

Metadata

Project
snapcraft
Number
#3026
Type
pull request
State
merged
Author
sergiusens
Labels
Created
Updated
Closed

Current evaluation

Merged. Added core20 support to spread tests, cleaned up system selection logic to exclusively install snaps, and introduced a dedicated environment for unit tests. A reported test failure was promptly fixed by the author before approval and merge.

Suggested action:

No scores available.

Issue body

Some systems were a bit greedy on their selections. Removed the logic to install deb or snap, we just install the snap. Added a specific environment for unit tests to identify easily. Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged. Added core20 support to spread tests, cleaned up system selection logic to exclusively install snaps, and introduced a dedicated environment for unit tests. A reported test failure was promptly fixed by the author before approval and merge.
qwen3.6-35b-a3b-mtp-q6 Merged after addressing a reported test failure. Updated spread tests to include core20, removed redundant deb and snap installation logic, and added a dedicated unit test environment identifier.
qwen3.6-35b-a3b-mtp-q6 Merged changes to spread tests adding core20 support and cleaning up system selection logic. Removed redundant deb and snap install steps, added a unit test environment variable, and fixed a reported test failure prior to merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6202 test(spread): create core26 spread test suite snapcraft merged Merged the core26 spread test suite, adding CI jobs and generalizing tests for core22, 24, and 26 across 419 files. Approved by two reviewers and passed most CI checks prior to integration.
77%
#5856 fix(spread): pack with lxd for core20 base tests snapcraft merged Merged after two approvals. Updates spread tests to pack with LXD for core20 base tests. CI passed with one non-blocking schema diff failure. Related core20 and snapd test failures were resolved in separate PRs.
76%
#3269 spread tests: remove references of core16 snapcraft merged Merged after single reviewer approval. The change removes all core16 references from the spread test suite, updating three files with a net reduction of eight lines. Changes were integrated into the main branch.
75%
#3714 spread: enable core22 snapcraft merged Merged into snapcraft/7.0 after reviewer approval and passing CI checks. The change enables core22 in the spread configuration across 36 files (+112/-58 lines). Code coverage remained unchanged upon merge.
75%
#6009 test: remove core20 spread tests snapcraft merged Merged removal of core20 spread tests and migration of related cases to core22 and core24. This update unblocks core20 deprecation for Snapcraft 9 and improves modern test coverage.
74%
#3540 spread tests: remove 16.04 and core (CRAFT-210) snapcraft merged Merged cleanup removing legacy 16.04 and core references from spread tests. Approved with passing CI. Author noted necessary legacy tests will be reintroduced in future iterations.
74%
#4056 spread: core24 testing infra snapcraft merged Merged after receiving two approvals and passing CI checks. Implements core24 testing infrastructure for spread, changing two files with a net addition of 16 lines. Code coverage remained unchanged.
74%
#2680 spread tests: minor performance improvements snapcraft merged Merged minor spread test performance improvements. Changes include conditional multipass installation, --purge on snap removals, and increasing GCE workers for 16.04 to 12. Approved, passed CI, and maintained coverage.
73%
#269 tests: add initial spread testing fetch-service merged Merged following approval by three reviewers. Adds initial spread testing infrastructure across 13 files, resolving issue #226. Validation confirms all 10 test tasks passed successfully on Ubuntu 20.04 and 22.04 LXD environments.
73%
#4761 tests: remove core24 snap workarounds snapcraft merged Merged after two approvals and passing CI. Removed core24 snap workarounds from spread tests, deleting 22 lines. Branch retargeted to hotfix/8.2 for release.
72%