← Back to issue list

tests: remove core24 snap workarounds

View original Github issue

Metadata

Project
snapcraft
Number
#4761
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged after two approvals and passing CI. Removed core24 snap workarounds from spread tests, deleting 22 lines. Branch retargeted to hotfix/8.2 for release.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Drop core24 workarounds in the spread tests.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two approvals and passing CI. Removed core24 snap workarounds from spread tests, deleting 22 lines. Branch retargeted to hotfix/8.2 for release.
qwen3.6-35b-a3b-mtp-q6 Merged after retargeting to hotfix/8.2. Removes core24 snap workarounds from spread tests. All modified lines passed code coverage checks.
qwen3.6-35b-a3b-mtp-q6 Merged after removing core24 snap workarounds from spread tests. The branch was retargeted to hotfix/8.2 to pass CI checks. Code coverage requirements were satisfied.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4763 tests: remove core24 snap workarounds (#4761) snapcraft merged Merged into main after two approvals and passing CI. The change cherry-picks test updates to remove core24 snap workarounds, resolving CI failures by deleting 22 lines of legacy code in a single file.
88%
#6009 test: remove core20 spread tests snapcraft merged Merged removal of core20 spread tests and migration of related cases to core22 and core24. This update unblocks core20 deprecation for Snapcraft 9 and improves modern test coverage.
77%
#4056 spread: core24 testing infra snapcraft merged Merged after receiving two approvals and passing CI checks. Implements core24 testing infrastructure for spread, changing two files with a net addition of 16 lines. Code coverage remained unchanged.
77%
#2417 fix: fix a series of breaking spread tests charmcraft merged Merged after fixing multiple breaking spread tests. Commits resolve individual failures, while remaining broken tests are marked non-blocking for core24 migration. Approved by reviewers and merged following CI validation.
75%
#386 tests: update testing to use craft-test fetch-service merged Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines).
75%
#3540 spread tests: remove 16.04 and core (CRAFT-210) snapcraft merged Merged cleanup removing legacy 16.04 and core references from spread tests. Approved with passing CI. Author noted necessary legacy tests will be reintroduced in future iterations.
75%
#2412 feat(snap): migrate the snap to core24 charmcraft merged Merged after two approvals. Migrates snap packaging to core24 across four files. Known test failures were deemed non-blocking. CI passed on most platforms despite Ubuntu 20.04 and 22.04 failures.
75%
#4582 test: add core24 component spread tests snapcraft merged Merged after approval and passing CI. Adds core24 component spread tests by flattening and copying existing test files. Coverage increased slightly, and changes were landed on the feature/components branch.
75%
#3714 spread: enable core22 snapcraft merged Merged into snapcraft/7.0 after reviewer approval and passing CI checks. The change enables core22 in the spread configuration across 36 files (+112/-58 lines). Code coverage remained unchanged upon merge.
74%
#3731 tests: fix content provider snap not found for core22 snapcraft merged Merged following reviewer approval and successful CI. Adjusted spread test expectations to match core22's distinct error message for missing content provider snaps. Modified three files, increasing test coverage by 0.08%.
74%