← Back to issue list

tests: remove core24 snap workarounds

View original Github issue

Metadata

Project
snapcraft
Number
#4761
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #4761 removed 22 lines of core24 workarounds from spread tests; it landed on hotfix/8.2 as 7cdd9b087 and was cherry-picked to main by #4763 as 87fc77aca.

Resolution: closed resolved

Reason: PR #4761 was approved and merged as commit 7cdd9b087. Follow-up PR #4763 cherry-picked the change to main as commit 87fc77aca.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Drop core24 workarounds in the spread tests.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #4761 removed 22 lines of core24 workarounds from spread tests; it landed on hotfix/8.2 as 7cdd9b087 and was cherry-picked to main by #4763 as 87fc77aca.
stealth/space-bunny-alpha — closed resolved PR #4761 (mr-cal) merged into hotfix/8.2 as commit 7cdd9b087, deleting 22 lines of core24 workarounds from spread tests; #4763 cherry-picked it to main as 87fc77aca.
stealth/space-bunny-alpha — closed resolved Merged in canonical/snapcraft#4761 as 7cdd9b087; #4763 cherry-picked the change to main as 87fc77aca, removing 22 lines of core24 workarounds from spread tests.
qwen/qwen3.6-35b-a3b — — Merged after two approvals and passing CI. Removed core24 snap workarounds from spread tests, deleting 22 lines. Branch retargeted to hotfix/8.2 for release.
qwen3.6-35b-a3b-mtp-q6 — — Merged after retargeting to hotfix/8.2. Removes core24 snap workarounds from spread tests. All modified lines passed code coverage checks.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#4763 (confidence 100%)

    Cherry-picked PR #4761 from hotfix/8.2 onto main as commit 87fc77aca.

Related issues

Issue Project State Summary Similarity
#4763 tests: remove core24 snap workarounds (#4761) snapcraft merged Merged: cherry-pick of #4761 onto main (87fc77aca), deleting 22 lines of core24 snap workarounds from spread tests so CI would pass.
94%
#6009 test: remove core20 spread tests snapcraft merged Squash-merged PR #6009 as commit d0f1b4394, deleting core20 spread tests and migrating applicable ones to core22/core24 (+20 net tests). Unblocked core20 lifecycle removal for Snapcraft 9 (#5675).
79%
#4748 tests: re-enable core24 linter spread test check snapcraft closed Closed unmerged; the core24 linter spread-test re-enable was superseded by canonical/snapcraft#4751, which tracks fixing the core22/core24 linker symbol lookup error.
78%
#2417 fix: fix a series of breaking spread tests charmcraft merged Merged PR #2417 at commit 3bee888e, fixing multiple spread-test failures and unblocking the core24 migration; three listed tests remained broken but non-blocking.
78%
#4056 spread: core24 testing infra snapcraft merged Merged PR #4056 as commit 1fee3d830, adding Spread test infrastructure for Ubuntu Core 24 (CRAFT-1639).
77%
#4932 Migrate or copy core20 and core22 spread tests to core24 snapcraft closed Core24 spread-test coverage was expanded via merged PR snapcraft#5209 (commit 56713c384), enabling plugin tests across 132 files.
77%
#77 core22-8 spread tests fail on classic-patchelf test snapcraft-rocks closed Fixed by merged PR #80, a core22-8 backport of #69 that enabled verbose output so Snapcraft messages appear in failing spread-test logs.
76%
#3026 spread tests: add core20 and cleanup systems snapcraft merged Merged #3026 in commit d006134d4, adding core20 spread tests, simplifying setup to install only the Snap, and cleaning up test systems.
75%
#4582 test: add core24 component spread tests snapcraft merged Merged #4582 into feature/components, adding core24 component spread tests by flattening and copying existing tests after CI passed.
75%
#6202 test(spread): create core26 spread test suite snapcraft merged Merged PR #6202 as a9a5b4750, adding core26 Spread tests and CI coverage while generalizing common tests for core22, core24, and core26.
74%