← Back to issue list

spread tests: remove references of core16

View original Github issue

Metadata

Project
snapcraft
Number
#3269
Type
pull request
State
merged
Author
cjp256
Labels
Created
Updated
Closed

Current evaluation

Merged after single reviewer approval. The change removes all core16 references from the spread test suite, updating three files with a net reduction of eight lines. Changes were integrated into the main branch.

Suggested action:

No scores available.

Issue body

Signed-off-by: Chris Patterson <chris.patterson@canonical.com> - [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `./runtests.sh static`? - [ ] Have you successfully run `./runtests.sh tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after single reviewer approval. The change removes all core16 references from the spread test suite, updating three files with a net reduction of eight lines. Changes were integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 Removed references to core16 from spread tests and merged into main. Maintainer cjp256 integrated the changes to align the test suite with current snap core versions.
qwen3.6-35b-a3b-mtp-q6 Merged update removing core16 references from spread tests. Authored by maintainer Chris Patterson, the changes were integrated directly into the codebase without additional review comments or revisions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3540 spread tests: remove 16.04 and core (CRAFT-210) snapcraft merged Merged cleanup removing legacy 16.04 and core references from spread tests. Approved with passing CI. Author noted necessary legacy tests will be reintroduced in future iterations.
84%
#6202 test(spread): create core26 spread test suite snapcraft merged Merged the core26 spread test suite, adding CI jobs and generalizing tests for core22, 24, and 26 across 419 files. Approved by two reviewers and passed most CI checks prior to integration.
78%
#4056 spread: core24 testing infra snapcraft merged Merged after receiving two approvals and passing CI checks. Implements core24 testing infrastructure for spread, changing two files with a net addition of 16 lines. Code coverage remained unchanged.
77%
#3714 spread: enable core22 snapcraft merged Merged into snapcraft/7.0 after reviewer approval and passing CI checks. The change enables core22 in the spread configuration across 36 files (+112/-58 lines). Code coverage remained unchanged upon merge.
76%
#3432 spread tests: remove legacy plugin tests snapcraft merged Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR.
76%
#3026 spread tests: add core20 and cleanup systems snapcraft merged Merged. Added core20 support to spread tests, cleaned up system selection logic to exclusively install snaps, and introduced a dedicated environment for unit tests. A reported test failure was promptly fixed by the author before approval and merge.
75%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration.
75%
#127 Fix spread tests imagecraft merged Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
73%
#1366 tests(spread): make release test less flaky charmcraft merged Merged changes that reduce flakiness in the spread release test, resolving issue #1362. Approved by two reviewers, the update modifies one file (+17/-7) after addressing feedback.
73%
#4177 core18: removal snapcraft merged Merged after two approvals and passing CI. Removes core18 support, resolving issue #4165. Changes span 528 files, deleting over 37,000 lines. Temporary core20 test fixes ensured CI passed prior to merge.
73%