← Back to issue list

lint: apply autoformat-black to source files

View original Github issue

Metadata

Project
snapcraft
Number
#3650
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged #3650 to scope autoformat-black to source files, matching test-black; landed in commit 0481269c4.

Resolution: closed resolved

Reason: PR #3650 was approved and merged into snapcraft/7.0. Its change was committed as abe7e76bb and included in merge commit 0481269c4.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `./runtests.sh static`? - [X] Have you successfully run `./runtests.sh tests/unit`? ----- `autoformat-black` should only apply to source files, matching `test-black`.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged #3650 to scope autoformat-black to source files, matching test-black; landed in commit 0481269c4.
stealth/space-bunny-alpha — — Merged #3650 to restrict autoformat-black to source files, matching test-black; landed in merge commit 0481269c4.
stealth/space-bunny-alpha — closed resolved Merged #3650 updated lint configuration so autoformat-black applies only to source files, matching test-black behavior.
qwen/qwen3.6-35b-a3b — — Merged following maintainer approval and passing CI. The update modifies the lint configuration to apply autoformat-black exclusively to source files, aligning it with test-black behavior.
qwen3.6-35b-a3b-mtp-q6 — — Merged into snapcraft/7.0, applying autoformat-black to source files to align with test-black. The change passed static and unit tests. Codecov noted a minor coverage decrease but did not block the merge.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3865 lint: lint legacy code with black snapcraft merged Merged as 789e162 (commit c34b94789): adds legacy code to the Makefile `test-black` target so Black linting matches the `autoformat-black` coverage added earlier in #3853 (806bfd04).
80%
#3853 lint: lint legacy code with black snapcraft merged Merged #3853 as 806bfd04, applying Black formatting to legacy code across 12 files (+84/-37); follow-up #3865 added those files to test-black linting.
79%
#3787 lint: apply black to parts directories snapcraft merged Merged PR #3787 in commit 79985df1, applying Black formatting to six files under snapcraft/parts/ and tests/unit/parts/, which Black previously ignored.
77%
#315 style: use black for consistent and automated formatting charmcraft merged Merged Black formatting across 36 files, added a formatting test, and ignored flake8 E203/W503 for Black compatibility in charmcraft#315 (merge commit ad135981).
73%
#2599 static: update to newer black snapcraft merged Merged #2599, applying formatting from a newer Black release across 15 files in commit 05913cd56.
72%
#638 style: update to black 2024 craft-parts merged Merged PR #638 as commit 423ad779, applying Black 2024 formatting to resolve formatting-related CI failures exposed by #627.
72%
#239 style(lint): autoformat starbase merged Merged PR #239 as commit 2439a13, applying a one-line autoformat change to one file after maintainer approval.
71%
#2603 black: minor format changes from updated black snapcraft merged Merged #2603 (commit b442ea48d) by cjp256, applying minor formatting-only changes (+4/-6 lines, 4 files) after Black was updated to the 19.10b0 syntax, keeping ./runtests.sh static passing.
71%