← Back to issue list

lint: apply black to parts directories

View original Github issue

Metadata

Project
snapcraft
Number
#3787
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #3787 in commit 79985df1, applying Black formatting to six files under snapcraft/parts/ and tests/unit/parts/, which Black previously ignored.

Resolution: closed resolved

Reason: PR #3787 was merged through merge commit 893aa7c1d, with resolving commit 79985df1 formatting the previously excluded parts directories.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- `snapcraft/parts/` and `tests/unit/parts/` were ignored by black.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #3787 in commit 79985df1, applying Black formatting to six files under snapcraft/parts/ and tests/unit/parts/, which Black previously ignored.
stealth/space-bunny-alpha — closed resolved Black formatting was applied to snapcraft/parts/ and tests/unit/parts/ in merged PR #3787 (commit 79985df); code coverage remained unchanged.
qwen/qwen3.6-35b-a3b — — Applied Black formatting to previously ignored snapcraft/parts/ and tests/unit/parts/ directories. Merged after reviewer approval and passing CI checks, with no impact on overall code coverage.
qwen3.6-35b-a3b-mtp-q6 — — Merged changes applying Black formatting to previously ignored snapcraft/parts/ and tests/unit/parts/ directories. The update standardizes code style across these modules while maintaining existing test coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#3853 lint: lint legacy code with black snapcraft merged Merged #3853 as 806bfd04, applying Black formatting to legacy code across 12 files (+84/-37); follow-up #3865 added those files to test-black linting.
78%
#3650 lint: apply autoformat-black to source files snapcraft merged Merged #3650 to scope autoformat-black to source files, matching test-black; landed in commit 0481269c4.
77%
#3865 lint: lint legacy code with black snapcraft merged Merged as 789e162 (commit c34b94789): adds legacy code to the Makefile `test-black` target so Black linting matches the `autoformat-black` coverage added earlier in #3853 (806bfd04).
75%
#2599 static: update to newer black snapcraft merged Merged #2599, applying formatting from a newer Black release across 15 files in commit 05913cd56.
72%
#4029 lint: reformat for black 23.1.0 snapcraft merged Merged PR #4029 (commit 51c24948) reformatting 66 files for Black 23.1.0. The only failing check was a setuptools>=66 unit-test breakage, fixed separately by #4031 pinning setuptools<66.
72%
#2603 black: minor format changes from updated black snapcraft merged Merged #2603 (commit b442ea48d) by cjp256, applying minor formatting-only changes (+4/-6 lines, 4 files) after Black was updated to the 19.10b0 syntax, keeping ./runtests.sh static passing.
71%
#1779765 Use black as the default code formatter snapcraft (launchpad) closed Merged canonical/snapcraft#2180, adopting Black as the standard Python style and reformatting 567 files in commit 96da199ac.
71%
#638 style: update to black 2024 craft-parts merged Merged PR #638 as commit 423ad779, applying Black 2024 formatting to resolve formatting-related CI failures exposed by #627.
71%