← Back to issue list

tests: remove arch_triplet from unit test (#4160)

View original Github issue

Metadata

Project
snapcraft
Number
#4172
Type
pull request
State
merged
Author
cmatsuoka
Labels
Created
Updated
Closed

Current evaluation

Merged changes removing arch_triplet from unit tests. The update deleted two lines in one file, passed CI checks, and received reviewer approval before integration.

Suggested action:

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged changes removing arch_triplet from unit tests. The update deleted two lines in one file, passed CI checks, and received reviewer approval before integration.
qwen3.6-35b-a3b-mtp-q6 Merged #4160 to remove arch_triplet from unit tests. The change was accepted by maintainer cmatsuoka despite a Codecov warning regarding missing base commit coverage.
qwen3.6-35b-a3b-mtp-q6 Merged PR #4160 removes arch_triplet from unit tests. Despite a Codecov warning about missing base commit coverage, the changes were successfully integrated.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4160 tests: remove arch_triplet from unit test snapcraft merged Merged a unit test fix removing remaining arch_triplet references. The change resolves file overlap from two prior PRs. Approved by one reviewer, passed CI, and deleted two lines from a single test file.
94%
#1928 tests: remove duplicate tests snapcraft merged Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time.
73%
#2014 integration tests: snap tests shouldn't be arch-specific snapcraft merged Merged a change removing architecture-specific constraints from snap integration tests. Approved by one reviewer with a two-line modification across a single file.
73%
#1895 tests: check that architecture "all" works charmcraft merged Merged following two approvals. Introduces tests for architecture all, resolving issue 1698. Depends on PR 1894. Updated 5 files (+70/-38).
70%