← Back to issue list

tests: remove arch_triplet from unit test

View original Github issue

Metadata

Project
snapcraft
Number
#4160
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged a unit test fix removing remaining arch_triplet references. The change resolves file overlap from two prior PRs. Approved by one reviewer, passed CI, and deleted two lines from a single test file.

Suggested action:

No scores available.

Issue body

- [X] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [X] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [X] Have you successfully run `make lint`? - [X] Have you successfully run `pytest tests/unit`? ----- Minor fix for unit tests. Two PRs ([1](https://github.com/snapcore/snapcraft/pull/4150) and [2](https://github.com/snapcore/snapcraft/pull/4152)) touched the same unit test file. One removed all references to `arch_triplet` and the other added 2 more tests with `arch_triplet` still present.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged a unit test fix removing remaining arch_triplet references. The change resolves file overlap from two prior PRs. Approved by one reviewer, passed CI, and deleted two lines from a single test file.
qwen3.6-35b-a3b-mtp-q6 Merged to resolve test conflicts by removing arch_triplet references. The update increased overall coverage by 0.04% and achieved 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged a fix removing remaining arch_triplet references from a unit test file to resolve a conflict with a prior PR. The change achieved 100% diff coverage and increased overall test coverage by 0.04%.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4172 tests: remove arch_triplet from unit test (#4160) snapcraft merged Merged changes removing arch_triplet from unit tests. The update deleted two lines in one file, passed CI checks, and received reviewer approval before integration.
94%
#1928 tests: remove duplicate tests snapcraft merged Merged changes that remove duplicate tests and clarify test base class names to prevent future duplication. Approved by two reviewers, passed CI, and reduced unit test execution time.
74%
#2014 integration tests: snap tests shouldn't be arch-specific snapcraft merged Merged a change removing architecture-specific constraints from snap integration tests. Approved by one reviewer with a two-line modification across a single file.
72%
#1895 tests: check that architecture "all" works charmcraft merged Merged following two approvals. Introduces tests for architecture all, resolving issue 1698. Depends on PR 1894. Updated 5 files (+70/-38).
72%
#73 tests: remove duplicated unit tests rockcraft merged Merged removal of duplicated unit tests from test_provider.py and test_providers.py, artifacts from a prior LXD and Multipass test consolidation. Approved, passed CI, and reduced two files by 60 lines.
70%
#117 go plugin: remove hardcoded arch triplet from test snapcraft merged Merged removal of the hardcoded architecture triplet from the Go plugin test. Approved by chipaca with a +4/-2 line change.
70%