← Back to issue list

type: workaround for pyright bug

View original Github issue

Metadata

Project
snapcraft
Number
#4243
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged into hotfix/7.5 as a cherry-pick of #3423. Resolves a pyright type-checking bug with a targeted workaround. Approved by one reviewer, passed CI, and modified 2 files (+4/-3 lines).

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- Cherry-pick #3423 into `hotfix/7.5`

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged into hotfix/7.5 as a cherry-pick of #3423. Resolves a pyright type-checking bug with a targeted workaround. Approved by one reviewer, passed CI, and modified 2 files (+4/-3 lines).
qwen3.6-35b-a3b-mtp-q6 Merged into hotfix/7.5 as a cherry-pick of #3423. Implements a workaround for a pyright bug. Code coverage checks passed with 100% diff coverage.
qwen3.6-35b-a3b-mtp-q6 Merged into hotfix/7.5 as a cherry-pick of #3423 to work around a pyright bug. The change achieved 100% diff coverage.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#4233 type: workaround for pyright bug snapcraft merged Merged a two-file change (+4/-3 lines) implementing a workaround for pyright bug #5394. Approved by one reviewer, passed CI checks, and successfully integrated into the codebase.
86%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions.
79%
#237 style: fix pyright config craft-cli merged Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated.
75%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%.
74%
#1525 build: enable pyright charmcraft merged Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff.
73%
#65 Fixed new pyright issues. craft-cli merged Merged a maintainer-submitted pull request resolving newly identified pyright type checking issues. The change modified two lines in a single file, received one reviewer approval, and was successfully integrated into the codebase.
72%
#158 style(types): update pyright craft-store merged Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards.
72%
#186 style(typing): update pyright craft-application merged Merged after updating pyright configuration and typing across seven files. Approved by two reviewers, passed CI checks, and maintained 99.28% test coverage with 29 additions and 20 deletions.
72%
#1574 style(type): enable stricter pyright rules charmcraft merged Merged changes enabling stricter pyright type checking rules. Approved by two reviewers, the update modifies three files with a +4/-15 line diff to enforce stricter static analysis standards.
71%
#4205 lint: fix for pyright 1.1.312 snapcraft merged Merged a fix for type errors in account.py triggered by Pyright 1.1.312's stricter kwargs validation. The change corrects type annotations, passes CI, and was approved by a reviewer.
70%