← Back to issue list

type: workaround for pyright bug

View original Github issue

Metadata

Project
snapcraft
Number
#4243
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged into hotfix/7.5 as b3dee0931, backporting a two-file typing workaround for microsoft/pyright#5394.

Resolution: closed resolved

Reason: PR #4243 merged into hotfix/7.5 with commit b3dee0931, applying the approved workaround for microsoft/pyright#5394.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `make lint`? - [ ] Have you successfully run `pytest tests/unit`? ----- Cherry-pick #3423 into `hotfix/7.5`

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged into hotfix/7.5 as b3dee0931, backporting a two-file typing workaround for microsoft/pyright#5394.
stealth/space-bunny-alpha — closed resolved Merged into hotfix/7.5, backporting the Pyright typing workaround from #4233; two files changed (+4/-3).
stealth/space-bunny-alpha — closed resolved Merged into hotfix/7.5 as 2190394, cherry-picking the targeted Pyright-bug type workaround from #3423; two files changed (+4/-3).
stealth/space-bunny-alpha — closed resolved Merged into hotfix/7.5, cherry-picking the targeted pyright bug workaround from #3423; the change updated two files (+4/-3 lines).
qwen/qwen3.6-35b-a3b — — Merged into hotfix/7.5 as a cherry-pick of #3423. Resolves a pyright type-checking bug with a targeted workaround. Approved by one reviewer, passed CI, and modified 2 files (+4/-3 lines).
qwen3.6-35b-a3b-mtp-q6 — — Merged into hotfix/7.5 as a cherry-pick of #3423. Implements a workaround for a pyright bug. Code coverage checks passed with 100% diff coverage.

Update history

No update history recorded yet.

Related work

  • Related To: snapcraft#4233 (confidence 98%)

    The equivalent mainline change merged as f5b2f2e0f before being backported.

  • Related To: pyright#5394 (confidence 95%)

    Upstream Pyright bug that motivated the typing workaround.

Related issues

Issue Project State Summary Similarity
#4233 type: workaround for pyright bug snapcraft merged Merged as f5b2f2e0f, adding a two-file typing workaround for microsoft/pyright#5394 after maintainer approval.
90%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged PR #342 fixed a Pyright possibly-unbound diagnostic with a small one-file change, landing as commit 06629929.
71%
#186 style(typing): update pyright craft-application merged Merged PR #186 as commit 43e6f1b9, updating Pyright configuration and typing across seven files (+29/-20).
70%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated.
70%