type: workaround for pyright bug
Metadata
Current evaluation
Merged as f5b2f2e0f, adding a two-file typing workaround for microsoft/pyright#5394 after maintainer approval.
Resolution: closed resolved
Reason: PR #4233 was merged in commit f5b2f2e0f, resolving the typing failure with a targeted workaround. It was approved with no unresolved review comments.
Evaluated by: mr-cal-bot
No scores available.
Issue body
https://github.com/microsoft/pyright/issues/5394
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as f5b2f2e0f, adding a two-file typing workaround for microsoft/pyright#5394 after maintainer approval. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4233 (commit f5b2f2e0f) added a two-file typing workaround for microsoft/pyright#5394, allowing type checking despite the upstream Pyright bug. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4233 (commit f5b2f2e0f) added a two-file typing workaround for microsoft/pyright#5394 so Snapcraft's lint checks could proceed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4233 added a two-file typing workaround for microsoft/pyright#5394 in commit f5b2f2e0f. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4233 as commit f5b2f2e0f, adding a small typing workaround for microsoft/pyright#5394. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4233 added a two-file typing workaround for microsoft/pyright#5394 after maintainer approval. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged into hotfix/7.5 via #4243 (commit b3dee0931), porting the pyright #5394 workaround merged in #4233 as f5b2f2e0f. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged a two-file change (+4/-3 lines) implementing a workaround for pyright bug #5394. Approved by one reviewer, passed CI checks, and successfully integrated into the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a workaround for pyright bug microsoft/pyright#5394. The change addresses type inference issues in the codebase. Author noted related spread test failures in comments. |
Update history
No update history recorded yet.
Related work
-
Related To:
pyright#5394
(confidence 100%)
Upstream Pyright bug that motivated the workaround.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4243 type: workaround for pyright bug | snapcraft | merged | Merged into hotfix/7.5 as b3dee0931, backporting a two-file typing workaround for microsoft/pyright#5394. | |
| #158 style(types): update pyright | craft-store | merged | Merged into main as commit 1b66727, updating Pyright typing configuration in two files after approval by two reviewers. | |
| #58 lint: fix typing issues with updated pyright | craft-archives | merged | Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated. | |
| #186 style(typing): update pyright | craft-application | merged | Merged PR #186 as commit 43e6f1b9, updating Pyright configuration and typing across seven files (+29/-20). | |
| #342 type: fix pyright possibly-unbound error | rockcraft | merged | Merged PR #342 fixed a Pyright possibly-unbound diagnostic with a small one-file change, landing as commit 06629929. | |
| #1528 Enable pyright and clear the typing issues | charmcraft | closed | Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation. | |
| #1525 build: enable pyright | charmcraft | merged | Merged PR #1525 as commit 6374ef9e, enabling Pyright with existing type errors downgraded to warnings for gradual adoption. | |
| #1294 style: enable strict type checking with pyright | craft-parts | merged | Merged as bb62329e, enabling strict Pyright type checking and fixing resulting errors across 58 files. | |
| #639 style: update pyright | craft-parts | merged | Merged #639 in commit 162a3522, updating Pyright and including codespell autofixes across four files. | |
| #65 Fixed new pyright issues. | craft-cli | merged | Maintainer PR fixing newly surfaced Pyright type errors (2-line change in 1 file). Merged into main as commit bbf67e4 via merge commit 88a68ac; Pyright was later dropped from the repo (#327, #479). |