type: workaround for pyright bug
Metadata
Current evaluation
Merged a two-file change (+4/-3 lines) implementing a workaround for pyright bug #5394. Approved by one reviewer, passed CI checks, and successfully integrated into the codebase.
Suggested action: —
No scores available.
Issue body
https://github.com/microsoft/pyright/issues/5394
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `make lint`?
- [x] Have you successfully run `pytest tests/unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged a two-file change (+4/-3 lines) implementing a workaround for pyright bug #5394. Approved by one reviewer, passed CI checks, and successfully integrated into the codebase. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a workaround for pyright bug microsoft/pyright#5394. The change addresses type inference issues in the codebase. Author noted related spread test failures in comments. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a workaround for a pyright type-checking bug. The PR bypasses microsoft/pyright#5394 by adjusting type annotations. Linting and unit tests passed prior to merge. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4243 type: workaround for pyright bug | snapcraft | merged | Merged into hotfix/7.5 as a cherry-pick of #3423. Resolves a pyright type-checking bug with a targeted workaround. Approved by one reviewer, passed CI, and modified 2 files (+4/-3 lines). | |
| #342 type: fix pyright possibly-unbound error | rockcraft | merged | Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions. | |
| #237 style: fix pyright config | craft-cli | merged | Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated. | |
| #1703 build: update pyright to 1.1.366 | charmcraft | merged | Merged update to pyright version 1.1.366. The change modified two files with a net reduction of five lines. Approved by one reviewer with no unresolved comments before integration. | |
| #1525 build: enable pyright | charmcraft | merged | Merged changes enabling pyright type checking. Configured a gradual rollout by downgrading type errors to warnings. Approved by two reviewers, the update modifies 12 files with a +60/-31 line diff. | |
| #58 lint: fix typing issues with updated pyright | craft-archives | merged | Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%. | |
| #515 build(deps): update pyright | craft-application | merged | Successfully merged pyright dependency update. Approved by two reviewers with no unresolved comments. Changes modify three files, adding five and removing three lines. | |
| #65 Fixed new pyright issues. | craft-cli | merged | Merged a maintainer-submitted pull request resolving newly identified pyright type checking issues. The change modified two lines in a single file, received one reviewer approval, and was successfully integrated into the codebase. | |
| #158 style(types): update pyright | craft-store | merged | Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards. | |
| #701 build(deps): update pyright to 1.1.358 | craft-parts | merged | Merged update to pyright version 1.1.358. Approved by two reviewers and passed CI. A lint issue was addressed separately in PR #702. The change modified three files with minimal adjustments. |