← Back to issue list

style(typing): update pyright

View original Github issue

Metadata

Project
craft-application
Number
#186
Type
pull request
State
merged
Author
lengau
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #186 as commit 43e6f1b9, updating Pyright configuration and typing across seven files (+29/-20).

Resolution: closed resolved

Reason: PR #186 was merged after maintainer approval. Commit 43e6f1b9 records the Pyright configuration and typing updates.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #186 as commit 43e6f1b9, updating Pyright configuration and typing across seven files (+29/-20).
stealth/space-bunny-alpha — closed resolved Merged PR #186, updating Pyright configuration and typing across seven files; 29 additions and 20 deletions.
qwen/qwen3.6-35b-a3b — — Merged after updating pyright configuration and typing across seven files. Approved by two reviewers, passed CI checks, and maintained 99.28% test coverage with 29 additions and 20 deletions.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#158 style(types): update pyright craft-store merged Merged into main as commit 1b66727, updating Pyright typing configuration in two files after approval by two reviewers.
89%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged PR #58 as commit 7983916, fixing typing issues across seven files after Pyright was updated.
84%
#1614 style(typing): enable most disabled pyright checks charmcraft merged Merged as commit 66952557, enabling most previously disabled Pyright checks and updating typing across 16 files.
84%
#639 style: update pyright craft-parts merged Merged #639 in commit 162a3522, updating Pyright and including codespell autofixes across four files.
82%
#1574 style(type): enable stricter pyright rules charmcraft merged Merged PR #1574 in commit 3445f5f4, enabling stricter Pyright type-checking rules across three files.
79%
#237 style: fix pyright config craft-cli merged Merged #237 (commit 675d42a), updating two Pyright ignore patterns so they apply recursively.
78%
#1294 style: enable strict type checking with pyright craft-parts merged Merged as bb62329e, enabling strict Pyright type checking and fixing resulting errors across 58 files.
77%
#215 style: drop mypy, pyright craft-grammar merged Merged #215 in commit 19a38b7, dropping mypy and pyright in favor of ty across six files (+4/-481).
76%
#2052 style(type): make pyright stricter charmcraft merged Merged PR canonical/charmcraft#2052, promoting two Pyright warnings to errors and fixing the resulting type errors across 16 files.
76%
#1528 Enable pyright and clear the typing issues charmcraft closed Pyright was enabled by merged PR #1525 (6374ef9e), then tightened by #1574 and #1614; #1528 was later closed without a maintainer explanation.
76%