← Back to issue list

style(typing): update pyright

View original Github issue

Metadata

Project
craft-application
Number
#186
Type
pull request
State
merged
Author
lengau
Labels
Created
Updated
Closed

Current evaluation

Merged after updating pyright configuration and typing across seven files. Approved by two reviewers, passed CI checks, and maintained 99.28% test coverage with 29 additions and 20 deletions.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the guidelines for contributing? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after updating pyright configuration and typing across seven files. Approved by two reviewers, passed CI checks, and maintained 99.28% test coverage with 29 additions and 20 deletions.
qwen3.6-35b-a3b-mtp-q6 Merged pyright configuration update to improve type checking. The change passed all CI checks and maintained 99.28% test coverage before integration.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#158 style(types): update pyright craft-store merged Merged following approval by two reviewers and successful CI checks. The change updated pyright type checking configuration, modifying two files with minimal adjustments to align with updated pyright standards.
91%
#639 style: update pyright craft-parts merged Merged a style update to pyright via an automated codespell autofix. Approved by two reviewers, passed CI checks, and modified four files.
87%
#58 lint: fix typing issues with updated pyright craft-archives merged Merged following reviewer approval and successful CI checks. Fixed typing errors introduced by an updated pyright version across seven files. Improved overall code coverage by 0.03%.
84%
#1574 style(type): enable stricter pyright rules charmcraft merged Merged changes enabling stricter pyright type checking rules. Approved by two reviewers, the update modifies three files with a +4/-15 line diff to enforce stricter static analysis standards.
80%
#1614 style(typing): enable most disabled pyright checks charmcraft merged Merged after approval by two reviewers, enabling most previously disabled pyright type checking rules. The update modifies 16 files (+94/-106 lines) to enforce stricter static type analysis across the codebase.
80%
#16 style: make pyright less concerned about grammar methods craft-grammar merged Merged a style update configuring pyright to reduce warnings for grammar methods. Approved by one reviewer, passed CI checks, and applied a minimal change of four additions and two deletions across one file.
79%
#237 style: fix pyright config craft-cli merged Merged a two-line fix to the pyright configuration, correcting ignores to apply recursively. Approved by two reviewers, passed CI, and integrated.
79%
#342 type: fix pyright possibly-unbound error rockcraft merged Merged to resolve a pyright possibly-unbound type error. Approved by two reviewers, passed CI checks, and modified one file with three additions and two deletions.
79%
#421 style: drop mypy, pyright craft-store merged Merged after approval from two reviewers; all CI checks passed. Replaces mypy and pyright with ty, removing 413 lines and adding 27 across 13 files.
78%
#479 style: drop mypy, pyright craft-cli merged Merged after approval from two reviewers; replaces mypy and pyright with ty, passing all CI checks. The change removed 341 lines and added 17 across 8 files.
78%