fix(tests): core24 classic linter test expectations
Metadata
Current evaluation
Merged after approval and passing CI. The change updates core24 classic linter test expectations. A maintainer noted a follow-up PR was needed for unit tests, and a reviewer later flagged a separate core22 spread failure.
Suggested action: —
No scores available.
Issue body
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged after approval and passing CI. The change updates core24 classic linter test expectations. A maintainer noted a follow-up PR was needed for unit tests, and a reviewer later flagged a separate core22 spread failure. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged updates to core24 classic linter test expectations. Coverage improved. A maintainer noted a follow-up PR was needed for unit tests, and a reviewer flagged a core22/core24 project class conflict causing spread failures, but the PR was merged. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged to update core24 classic linter test expectations. The change exposed a shared Project class conflict between core22 and core24, triggering spread failures. A follow-up PR was required to resolve the architectural issue. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4748 tests: re-enable core24 linter spread test check | snapcraft | closed | Superseded and closed without merging. The core24 linter test check was redirected to PR #4751 to resolve a core22/core24 environment symbol lookup error. All related fixes and tracking are now handled there. | |
| #4557 feat!: fail if we know the project is core24 | snapcraft | merged | Merged a breaking change that fails early for core24 projects. Added core24 spread tests with expected failures and updated CI workflows. Approved by two reviewers and passed all checks. | |
| #5209 tests: enable core24 plugin tests | snapcraft | merged | Merged after four reviewers approved. The changes enable core24 plugin tests across 132 files, adding 2,795 lines. CI checks passed and the code was successfully integrated into the main branch. | |
| #4582 test: add core24 component spread tests | snapcraft | merged | Merged after approval and passing CI. Adds core24 component spread tests by flattening and copying existing test files. Coverage increased slightly, and changes were landed on the feature/components branch. | |
| #5378 test: fix extension tests | snapcraft | merged | Merged unit test updates for expand_extensions(). No code changes were needed as existing logic already handles core22 and core24 correctly. Approved by two reviewers and passed CI checks prior to merge. | |
| #6202 test(spread): create core26 spread test suite | snapcraft | merged | Merged the core26 spread test suite, adding CI jobs and generalizing tests for core22, 24, and 26 across 419 files. Approved by two reviewers and passed most CI checks prior to integration. | |
| #4056 spread: core24 testing infra | snapcraft | merged | Merged after receiving two approvals and passing CI checks. Implements core24 testing infrastructure for spread, changing two files with a net addition of 16 lines. Code coverage remained unchanged. | |
| #4595 tests(spread): remove core24 ros2 extension linter tests | snapcraft | merged | Merged removal of core24 ros2 extension linter tests, as no ROS 24.04 or extension exists. Approved by two reviewers, passed CI, and maintained coverage. Deleted 101 lines across five files. | |
| #4597 fix(tests): expect the proper libpng version in core24 linter test | snapcraft | merged | Merged a one-line fix updating the expected libpng version in the core24 linter test, resolving the library-unused failure. Approved by two reviewers, passed CI, and merged into feature/craft-application. | |
| #2417 fix: fix a series of breaking spread tests | charmcraft | merged | Merged after fixing multiple breaking spread tests. Commits resolve individual failures, while remaining broken tests are marked non-blocking for core24 migration. Approved by reviewers and merged following CI validation. |