← Back to issue list

tests: enable core24 plugin tests

View original Github issue

Metadata

Project
snapcraft
Number
#5209
Type
pull request
State
merged
Author
sergiusens
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5209 as commit 56713c384, enabling core24 plugin tests across 132 files and expanding core24 test coverage.

Resolution: closed resolved

Reason: The pull request was merged as commit 56713c384. Its changes enabled the core24 plugin test suite across 132 files and addressed the related test-migration request in #4932.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [ ] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [ ] Have you successfully run `tox run -m lint`? - [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) -----

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5209 as commit 56713c384, enabling core24 plugin tests across 132 files and expanding core24 test coverage.
stealth/space-bunny-alpha — closed resolved Merged PR #5209 via commit 56713c384, enabling core24 plugin tests across 132 files and expanding coverage.
qwen/qwen3.6-35b-a3b — — Merged after four reviewers approved. The changes enable core24 plugin tests across 132 files, adding 2,795 lines. CI checks passed and the code was successfully integrated into the main branch.
qwen3.6-35b-a3b-mtp-q6 — — Merged the changes enabling core24 plugin tests. Reviewers noted unrelated CI failures from separate issues, and the code was successfully integrated into the main branch.

Update history

No update history recorded yet.

Related work

  • Likely Fixed By: canonical/snapcraft#4932 (confidence 96%)

    The core20/core22-to-core24 test migration request was addressed by this merged coverage expansion.

  • Related To: canonical/snapcraft#5977 (confidence 90%)

    A later merged PR re-enabled the core24 Python Spread test, continuing this coverage work.

  • Related To: canonical/snapcraft#5217 (confidence 88%)

    A review comment linked the OSV failure to this separate issue.

  • Related To: canonical/snapcraft#5258 (confidence 88%)

    A review comment linked the Flutter Spread failures to this separate issue.

Related issues

Issue Project State Summary Similarity
#4932 Migrate or copy core20 and core22 spread tests to core24 snapcraft closed Core24 spread-test coverage was expanded via merged PR snapcraft#5209 (commit 56713c384), enabling plugin tests across 132 files.
80%
#5977 test: re-enable core24 python test snapcraft merged PR #5977 merged as 3743f75c4, re-enabling the core24 Python Spread test after it began passing again and closing #5207.
76%
#4862 tests: add a test for package filtering in core24 snapcraft merged Merged PR #4862 (commit 2d16cd861) added core24 package-filtering test coverage and closed #4865 after a craft-parts bump and update onto hotfix/8.2.
76%
#6202 test(spread): create core26 spread test suite snapcraft merged Merged PR #6202 as a9a5b4750, adding core26 Spread tests and CI coverage while generalizing common tests for core22, core24, and core26.
76%
#4582 test: add core24 component spread tests snapcraft merged Merged #4582 into feature/components, adding core24 component spread tests by flattening and copying existing tests after CI passed.
75%
#4763 tests: remove core24 snap workarounds (#4761) snapcraft merged Merged: cherry-pick of #4761 onto main (87fc77aca), deleting 22 lines of core24 snap workarounds from spread tests so CI would pass.
74%
#5378 test: fix extension tests snapcraft merged Merged #5378 in commit 510908ecd, correcting expand_extensions() unit tests; core22 and core24 already behaved correctly, so no production changes were needed.
73%
#4056 spread: core24 testing infra snapcraft merged Merged PR #4056 as commit 1fee3d830, adding Spread test infrastructure for Ubuntu Core 24 (CRAFT-1639).
72%
#2417 fix: fix a series of breaking spread tests charmcraft merged Merged PR #2417 at commit 3bee888e, fixing multiple spread-test failures and unblocking the core24 migration; three listed tests remained broken but non-blocking.
72%
#4761 tests: remove core24 snap workarounds snapcraft merged Merged #4761 removed 22 lines of core24 workarounds from spread tests; it landed on hotfix/8.2 as 7cdd9b087 and was cherry-picked to main by #4763 as 87fc77aca.
72%