tests(spread): remove core24 ros2 extension linter tests
Metadata
Current evaluation
Merged removal of core24 ros2 extension linter tests, as no ROS 24.04 or extension exists. Approved by two reviewers, passed CI, and maintained coverage. Deleted 101 lines across five files.
Suggested action: —
No scores available.
Issue body
There is no ROS for 24.04, nor an extension for it.
- [ ] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [ ] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [ ] Have you successfully run `tox run -m lint`?
- [ ] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged removal of core24 ros2 extension linter tests, as no ROS 24.04 or extension exists. Approved by two reviewers, passed CI, and maintained coverage. Deleted 101 lines across five files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed linter tests for the core24 ros2 extension since ROS 24.04 and its extension do not exist. Code coverage checks passed. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Removed linter tests for a ROS2 extension on core24, as the extension does not exist for that release. All modified lines passed coverage checks. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4791 extension: add ROS 2 Jazzy (core24) | snapcraft | merged | Merged the ROS 2 Jazzy extension for core24. Approved by reviewers, the change modifies 13 files with 722 additions and 20 deletions. CI passed after updating codespell dependencies to resolve legacy flagging. | |
| #4113 tests: update linter-ros2-humble-mixed spread test | snapcraft | merged | Merged into main after approval and passing CI. Updates a broken ros2 humble spread test caused by removed extension libraries, removing 7 lines of outdated code to restore test stability. | |
| #4748 tests: re-enable core24 linter spread test check | snapcraft | closed | Superseded and closed without merging. The core24 linter test check was redirected to PR #4751 to resolve a core22/core24 environment symbol lookup error. All related fixes and tracking are now handled there. | |
| #5209 tests: enable core24 plugin tests | snapcraft | merged | Merged after four reviewers approved. The changes enable core24 plugin tests across 132 files, adding 2,795 lines. CI checks passed and the code was successfully integrated into the main branch. | |
| #4600 fix(tests): core24 classic linter test expectations | snapcraft | merged | Merged after approval and passing CI. The change updates core24 classic linter test expectations. A maintainer noted a follow-up PR was needed for unit tests, and a reviewer later flagged a separate core22 spread failure. | |
| #4369 test(spread): make ros linter test less strict | snapcraft | merged | Merged into main after two approvals and passing CI. The change relaxes the ROS linter spread test to properly filter libpng warnings while retaining ros2-humble checks, resolving issue #4256. | |
| #4763 tests: remove core24 snap workarounds (#4761) | snapcraft | merged | Merged into main after two approvals and passing CI. The change cherry-picks test updates to remove core24 snap workarounds, resolving CI failures by deleting 22 lines of legacy code in a single file. | |
| #5378 test: fix extension tests | snapcraft | merged | Merged unit test updates for expand_extensions(). No code changes were needed as existing logic already handles core22 and core24 correctly. Approved by two reviewers and passed CI checks prior to merge. | |
| #4203 ros: remove linter warnings from spread tests | snapcraft | merged | Cherry-picked and merged PR #4202 onto hotfix/7.4, removing linter warnings from ROS spread tests. Approved by one reviewer, passed CI, and deleted seven lines across one file. | |
| #4761 tests: remove core24 snap workarounds | snapcraft | merged | Merged after two approvals and passing CI. Removed core24 snap workarounds from spread tests, deleting 22 lines. Branch retargeted to hotfix/8.2 for release. |