tests: drop `grade: devel` from core24 spread tests
Metadata
Current evaluation
Merged in commit 500872360 via #4750, removing grade: devel from unrelated core24 spread tests while adding dedicated grade coverage.
Resolution: closed resolved
Reason: PR #4750 was approved and merged as commit 500872360. It retained grade coverage in the craftctl get/set test and added a dedicated grade spread test.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Simplify the `core24` spread tests by dropping `grade` from all tests except for `tests/spread/core24/craftctl/test-craftctl-get-set` (which tests updating the grade).
I added a new spread test to test the grade explicitly.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged in commit 500872360 via #4750, removing grade: devel from unrelated core24 spread tests while adding dedicated grade coverage. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#4750 (commit 500872360), simplifying core24 spread tests and adding dedicated grade coverage. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged following approval and CI checks. Simplified core24 spread tests by removing grade devel from all but one test that explicitly validates grade updates. Added a new dedicated grade test across 52 files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Simplified core24 spread tests by removing the grade: devel directive from all but the craftctl test. Added a new dedicated spread test to explicitly verify grade handling. |
Update history
No update history recorded yet.
Related work
-
Related To:
snapcraft#4734
(confidence 78%)
Earlier change removed the devel build-base requirement for core24, providing context for the grade test simplification.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4761 tests: remove core24 snap workarounds | snapcraft | merged | Merged #4761 removed 22 lines of core24 workarounds from spread tests; it landed on hotfix/8.2 as 7cdd9b087 and was cherry-picked to main by #4763 as 87fc77aca. | |
| #4763 tests: remove core24 snap workarounds (#4761) | snapcraft | merged | Merged: cherry-pick of #4761 onto main (87fc77aca), deleting 22 lines of core24 snap workarounds from spread tests so CI would pass. | |
| #5297 test: re-enable devel spread tests | snapcraft | merged | Merged in #5297 (commit 65a6004f5), re-enabling and simplifying devel spread tests, adding a second test, and resolving #4921. | |
| #2417 fix: fix a series of breaking spread tests | charmcraft | merged | Merged PR #2417 at commit 3bee888e, fixing multiple spread-test failures and unblocking the core24 migration; three listed tests remained broken but non-blocking. | |
| #6202 test(spread): create core26 spread test suite | snapcraft | merged | Merged PR #6202 as a9a5b4750, adding core26 Spread tests and CI coverage while generalizing common tests for core22, core24, and core26. | |
| #4922 tests: disable `build-base: devel` spread tests | snapcraft | merged | Merged PR (commit 8aa87427a) temporarily disabling `build-base: devel` spread tests to unblock CI while 24.04/24.10 systemd-resolved failures were debugged; fixes #4910, re-enabled later by #5297. | |
| #4582 test: add core24 component spread tests | snapcraft | merged | Merged #4582 into feature/components, adding core24 component spread tests by flattening and copying existing tests after CI passed. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%. |