← Back to issue list

tests: drop `grade: devel` from core24 spread tests

View original Github issue

Metadata

Project
snapcraft
Number
#4750
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged following approval and CI checks. Simplified core24 spread tests by removing grade devel from all but one test that explicitly validates grade updates. Added a new dedicated grade test across 52 files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- Simplify the `core24` spread tests by dropping `grade` from all tests except for `tests/spread/core24/craftctl/test-craftctl-get-set` (which tests updating the grade). I added a new spread test to test the grade explicitly.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged following approval and CI checks. Simplified core24 spread tests by removing grade devel from all but one test that explicitly validates grade updates. Added a new dedicated grade test across 52 files.
qwen3.6-35b-a3b-mtp-q6 Merged. Simplified core24 spread tests by removing the grade: devel directive from all but the craftctl test. Added a new dedicated spread test to explicitly verify grade handling.
qwen3.6-35b-a3b-mtp-q6 Merged updates that simplify core24 spread tests by removing the grade: devel constraint from all tests except one explicitly testing grade updates. A new dedicated test verifies grade functionality.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#6202 test(spread): create core26 spread test suite snapcraft merged Merged the core26 spread test suite, adding CI jobs and generalizing tests for core22, 24, and 26 across 419 files. Approved by two reviewers and passed most CI checks prior to integration.
74%
#4056 spread: core24 testing infra snapcraft merged Merged after receiving two approvals and passing CI checks. Implements core24 testing infrastructure for spread, changing two files with a net addition of 16 lines. Code coverage remained unchanged.
74%
#4582 test: add core24 component spread tests snapcraft merged Merged after approval and passing CI. Adds core24 component spread tests by flattening and copying existing test files. Coverage increased slightly, and changes were landed on the feature/components branch.
74%
#5677 Add core26 support snapcraft closed Core26 support was completed via pull request #5767. The enhancement updated code for core24_or_newer compatibility, enforced grade: devel until stable promotion, and added core26 spread test suites.
73%
#4761 tests: remove core24 snap workarounds snapcraft merged Merged after two approvals and passing CI. Removed core24 snap workarounds from spread tests, deleting 22 lines. Branch retargeted to hotfix/8.2 for release.
73%
#4600 fix(tests): core24 classic linter test expectations snapcraft merged Merged after approval and passing CI. The change updates core24 classic linter test expectations. A maintainer noted a follow-up PR was needed for unit tests, and a reviewer later flagged a separate core22 spread failure.
72%
#5297 test: re-enable devel spread tests snapcraft merged Merged following two approvals. Re-enables the devel spread test suite, simplifies the existing test, and adds a new simple test. Resolves #4921. Diff: +34/-15 across 5 files.
72%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration.
71%
#2417 fix: fix a series of breaking spread tests charmcraft merged Merged after fixing multiple breaking spread tests. Commits resolve individual failures, while remaining broken tests are marked non-blocking for core24 migration. Approved by reviewers and merged following CI validation.
71%
#386 tests: update testing to use craft-test fetch-service merged Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines).
71%