← Back to issue list

tests(spread): drop check for specific files in ppa tests

View original Github issue

Metadata

Project
snapcraft
Number
#4772
Type
pull request
State
merged
Author
mr-cal
Labels
Created
Updated
Closed

Current evaluation

Merged after two approvals and passing CI. Removes an outdated file check from PPA spread tests, as the source package changed and the test is no longer relevant. Eight lines were deleted across two files.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `tox run -m lint`? - [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`) ----- The source package has changed and the test isn't particularly important.

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged after two approvals and passing CI. Removes an outdated file check from PPA spread tests, as the source package changed and the test is no longer relevant. Eight lines were deleted across two files.
qwen3.6-35b-a3b-mtp-q6 Merged a change dropping an obsolete file check in PPA spread tests. The test was removed because the source package changed, rendering it unnecessary. The PR passed all lint and test checks before merging.
qwen3.6-35b-a3b-mtp-q6 Merged removal of an outdated file check from PPA spread tests, as the source package structure changed and the test lost relevance.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1366 tests(spread): make release test less flaky charmcraft merged Merged changes that reduce flakiness in the spread release test, resolving issue #1362. Approved by two reviewers, the update modifies one file (+17/-7) after addressing feedback.
76%
#1502 test(spread): disable centos spread test charmcraft merged Merged a change disabling the CentOS spread test. The update modifies one file with three added lines, received approval from two reviewers, and was integrated without CI checks or comments.
75%
#3432 spread tests: remove legacy plugin tests snapcraft merged Merged removal of legacy plugin tests from the spread test suite. Deleted 665 lines across 29 files. Approved by reviewer, passed CI, and maintained coverage. Unrelated test failures were addressed in a separate PR.
74%
#127 Fix spread tests imagecraft merged Merged after receiving approval from two reviewers and passing all CI checks. The changes fix spread tests across 11 files (+49/-38 lines).
74%
#3662 tests: update spread url snapcraft merged Merged update to spread tarball URLs in test files. Approved by a reviewer, passed CI checks, modified two files with minimal changes, and maintained existing code coverage.
74%
#1290 test(spread): clean up store tests charmcraft merged Merged cleanup of spread store tests, removing 28 lines across four files. The underlying library test failure is fixed in PR #1292. Approved by two reviewers.
73%
#5406 test: drop verbose flags in spread tests snapcraft merged Merged following approval from two reviewers. Removes verbose flags from spread tests as a follow-up to #5389. All CI checks passed, modifying 8 lines across 6 files.
73%
#1503 test(spread): disable centos spread test charmcraft merged Merged to disable the CentOS spread test. Approved by two reviewers, the change modifies one file with three lines added and is now part of the main branch.
73%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged minor spread test cleanups into master. Modified four files with 16 additions and 6 deletions. Approved by one reviewer with zero unresolved comments, maintaining 95.27% coverage upon integration.
73%
#534 test(spread): workaround for flaky test fetch-service merged Merged a workaround for a flaky spread test (issue #533). The change adjusts one file (+2/-1 lines) to skip a no-op name query check while retaining other validations. Approved by two reviewers and passed all CI checks.
73%