tests(spread): drop check for specific files in ppa tests
Metadata
Current evaluation
Merged PR #4772 removed eight obsolete file-specific checks from PPA spread tests after the source package changed.
Resolution: closed resolved
Reason: PR #4772 was approved by two reviewers with no unresolved comments and merged. It updated two test files to remove eight outdated assertions.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
The source package has changed and the test isn't particularly important.
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4772 removed eight obsolete file-specific checks from PPA spread tests after the source package changed. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #4772, removing an outdated eight-line file check from PPA spread tests after the source package changed. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged after two approvals and passing CI. Removes an outdated file check from PPA spread tests, as the source package changed and the test is no longer relevant. Eight lines were deleted across two files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a change dropping an obsolete file check in PPA spread tests. The test was removed because the source package changed, rendering it unnecessary. The PR passed all lint and test checks before merging. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #13 test(spread): add more spread tests | snapcraft-rocks | merged | Merged PR #13 added Spread tests for architectures, Chisel slices, craftctl, package repositories, and patchelf (+206/-5 across 15 files). | |
| #127 Fix spread tests | imagecraft | merged | Fixed and merged as commit cd43de1, updating 11 files (+49/-38); all listed CI checks, including spread, passed. | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged #1366 at commit 05b18a03, reducing flakiness in the Spread release test and resolving #1362. | |
| #5406 test: drop verbose flags in spread tests | snapcraft | merged | Merged PR #5406 (c4722d22f) removed verbose flags from six spread test files as a follow-up to #5389, despite three spread integration checks failing. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%. | |
| #240 tests: check for submodules before running spread | rockcraft | merged | Merged PR #240 as commit 3d940f71, adding a preflight check so spread tests report a clear error when the snapd-testing-tools submodule is missing. |