← Back to issue list

test: drop verbose flags in spread tests

View original Github issue

Metadata

Project
snapcraft
Number
#5406
Type
pull request
State
merged
Author
mr-cal
Labels
—
Created
Updated
Closed

Current evaluation

Merged PR #5406 (c4722d22f) removed verbose flags from six spread test files as a follow-up to #5389, despite three spread integration checks failing.

Resolution: closed resolved

Reason: PR #5406 was merged as commit c4722d22f, updating six files (+8/-8) to remove verbose flags from spread test commands. The change was approved with no unresolved review comments.

Evaluated by: mr-cal-bot

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] Have you successfully run `make lint`? - [x] Have you successfully run `make test`? --- Follow up to #5389 to remove verbose flags from spread tests.

Evaluation history

Date Model Scores Action Summary
stealth/space-bunny-alpha — closed resolved Merged PR #5406 (c4722d22f) removed verbose flags from six spread test files as a follow-up to #5389, despite three spread integration checks failing.
stealth/space-bunny-alpha — closed resolved PR #5406 (commit c4722d22f) merged, removing --verbose flags from six spread test files; follow-up to #5389 which had added trace logging. Approved by 2 reviewers; some spread jobs were still red.
stealth/space-bunny-alpha — closed resolved Merged PR #5406 (c4722d22f) removed verbose flags from six spread test files as a follow-up to #5389, despite three failing spread integration checks.
qwen/qwen3.6-35b-a3b — — Merged following approval from two reviewers. Removes verbose flags from spread tests as a follow-up to #5389. All CI checks passed, modifying 8 lines across 6 files.
qwen3.6-35b-a3b-mtp-q6 — — Removed verbose flags from spread tests as a follow-up to #5389. The change was merged to streamline test execution and reduce output verbosity.

Update history

No update history recorded yet.

Related work

  • Related To: canonical/snapcraft#5389 (confidence 100%)

    PR #5406 is explicitly described as a follow-up to merged PR #5389.

Related issues

Issue Project State Summary Similarity
#5389 test(spread): trace logs in spread tests snapcraft merged Merged PR #5389 as ff6f5950e, adding trace logging to spread tests for better failure diagnostics.
74%
#1287 tests: minor cleanups on the spread tests snapcraft merged Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%.
73%
#2763 fix(tests/spread): fix reactive spread tests charmcraft merged Merged #2763 as 6e775f4a: split reactive spread coverage by legacy/Resolute, enabled binary wheels, and removed obsolete build flags.
72%
#1366 tests(spread): make release test less flaky charmcraft merged Merged #1366 at commit 05b18a03, reducing flakiness in the Spread release test and resolving #1362.
72%
#753 chore(services/testing): reduce spread verbosity level craft-application merged Merged PR #753 removed forced verbose mode from Spread test execution, reducing output noise from the test command.
71%
#534 test(spread): workaround for flaky test fetch-service merged Merged PR #534 (commit 4f89bb7) worked around #533 by skipping the flaky snap names-query assertion while retaining the other spread-test checks.
71%
#4772 tests(spread): drop check for specific files in ppa tests snapcraft merged Merged PR #4772 removed eight obsolete file-specific checks from PPA spread tests after the source package changed.
71%
#4433 tests(spread): add remote-build spread test snapcraft merged Merged #4433 (commit 4a0a91117), adding weekly spread coverage for new and legacy remote-build implementations and resolving #4398.
70%