tests: fix validation sets spread test
Metadata
Current evaluation
Merged PR #5075 (commit a22b218ab) fixed #5053 by making the validation-sets spread test use hello-world and check presence instead of a fixed revision.
Resolution: closed resolved
Reason: PR #5075 was approved and merged as commit a22b218ab. It explicitly fixes #5053 by updating the validation-sets spread test to use hello-world and flip presence rather than depend on a specific snap revision.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
[Behind the scenes](https://github.com/canonical/snapcraft/pull/5074/files#diff-610b821ececc50adda118ec968fe837957ad1941ad14c938e7e61830d9b0d929R7-R17), I updated the validation sets spread test to use the `hello-world` snap.
This PR flip-flops the `presence` instead of the `revision`, which should make it a little more robust because it won't depend on a specific revision of the snap being accessible.
Fixes #5053
(CRAFT-3418)
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5075 (commit a22b218ab) fixed #5053 by making the validation-sets spread test use hello-world and check presence instead of a fixed revision. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5075 (a22b218ab) fixed #5053 by updating the validation-sets spread test to use hello-world and check presence instead of a fixed revision. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged PR #5075 (commit a22b218ab) fixed #5053 by switching the validation-sets test to hello-world and flipping presence instead of checking a fixed revision. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged fix for validation sets spread test switching to the hello-world snap and flipping the presence check instead of a specific revision. Approved by two reviewers with passing CI, resolving issue #5053. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a fix for the validation sets spread test. The update switches to the hello-world snap and flips the presence check instead of revision to improve robustness. Resolves #5053. Reviewer noted unrelated test errors. |
Update history
No update history recorded yet.
Related work
-
Likely Fixed By:
canonical/snapcraft#5053
(confidence 100%)
PR #5075 explicitly states that it fixes issue #5053, which was closed by the merged change.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #4924 tests: add spread tests for validation-sets | snapcraft | merged | Merged PR #4924 added spread coverage for edit-validation-sets and list-validation-sets, closing #4918; merge commit 157d0a182. | |
| #4918 Test validation-set commands | snapcraft | closed | Added and merged spread tests for edit-validation-sets and list-validation-sets in PR #4924 (commit 157d0a182), resolving #4918. | |
| #5053 Fix validation-sets spread test | snapcraft | closed | Fixed validation-sets spread-test coverage in commit a22b218ab after staging-store cleanup removed the required test snap. | |
| #1287 tests: minor cleanups on the spread tests | snapcraft | merged | Merged into master as commit 1cf0f8c9f "tests: minor cleanups on the spread tests (#1287)" — a test-only tidy-up touching 4 spread test files (+16/-6), reviewed and approved by fgimenez, with coverage unchanged at 95.27%. | |
| #2400 tests: fix maven spread test | snapcraft | merged | Merged PR #2400 as commit 155306683, correcting the Maven spread test with a two-line change. | |
| #1366 tests(spread): make release test less flaky | charmcraft | merged | Merged #1366 at commit 05b18a03, reducing flakiness in the Spread release test and resolving #1362. | |
| #4954 tests: update spread tests in hotfix/7.5 | snapcraft | merged | Merged PR #4954 into hotfix/7.5 with six cherry-picks and six commits repairing CI and spread tests; it unblocked icon fixes for #4950 and #4936. | |
| #926 test: address a couple of non-flaky spread failures | rockcraft | merged | Merged PR #926 updated three spread-test configuration files to address persistent failures; all CI checks passed and two reviewers approved. | |
| #3662 tests: update spread url | snapcraft | merged | Merged PR #3662 updated Spread tarball URLs in two test files via commit 507959d70. | |
| #415 test: fix typo in spread extension | fetch-service | closed | PR #415 was closed after approval was retracted; its typo fix was incorporated into merged PR #417 via commit 8363f15. |