tests: clean up fifos
Metadata
Current evaluation
Merged changes clean up cached FIFOs in the .tox directory that previously broke snapcraft snap builds. Approved by three reviewers with passing CI checks.
Suggested action: —
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/canonical/snapcraft/blob/main/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] Have you successfully run `tox run -m lint`?
- [x] Have you successfully run `tox run -e test-py310`? (supported versions: `py39`, `py310`, `py311`, `py312`)
-----
Fifos get cached in `.tox/` when running tests and then cause the snapcraft snap to fail to build when snapcraft tries to copy the fifo.
source: @sergio-costas via https://chat.canonical.com/canonical/pl/6jpni1n98ifc3fph9ywmdus4iy
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes clean up cached FIFOs in the .tox directory that previously broke snapcraft snap builds. Approved by three reviewers with passing CI checks. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a patch to remove cached FIFOs from the .tox directory. This resolves snapcraft snap build failures triggered when copying stale FIFOs generated during test execution. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged. Fixes snapcraft build failures caused by FIFOs cached in .tox during tests. The patch cleans up temporary FIFOs post-test, preventing copy errors during packaging. Verified by maintainer. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #85 test: cleanup test now that we have a new enough snapcraft | snapcraft-rocks | merged | Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged. | |
| #5033 docs: document tox builds | snapcraft | merged | Merged following two reviewer approvals and passing CI. The update documents tox build workflows in HACKING.md and removes snapcraft_legacy from autobuild targets, resolving a previous blocking issue. | |
| #1652 tests: fork skip into snaps_tests | snapcraft | merged | Merged changes that forked skip into snaps_tests to prevent overly broad imports in snapcraft.tests from breaking autopackage tests. Approved by two reviewers, passed CI, and modified three files. | |
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change. | |
| #2421 tests: remove obsolete snap and external tests | snapcraft | merged | Merged after maintainer approval, removing obsolete snap and external tests. Accepted despite minor coverage drop and unrelated CI failures, though later noted to break documentation. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged tests for missing snap scenarios. Approved by two reviewers and integrated into the codebase despite unresolved review comments and reported integration test timeouts. |