tests: fork skip into snaps_tests
Metadata
Current evaluation
Merged changes that forked skip into snaps_tests to prevent overly broad imports in snapcraft.tests from breaking autopackage tests. Approved by two reviewers, passed CI, and modified three files.
Suggested action: —
No scores available.
Issue body
This is to avoid the overly broad imports done in
snapcraft.tests which break autopackage tests.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| qwen/qwen3.6-35b-a3b | — | — | Merged changes that forked skip into snaps_tests to prevent overly broad imports in snapcraft.tests from breaking autopackage tests. Approved by two reviewers, passed CI, and modified three files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes that fork the skip logic into snaps_tests to prevent overly broad imports in snapcraft.tests from breaking autopackage tests. The pull request passed static and unit checks and was successfully integrated. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged a change that forks the skip logic into snaps_tests, resolving overly broad imports in snapcraft.tests that broke autopackage tests. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1948 tests: move test files out of the snapcraft dir | snapcraft | merged | Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions. | |
| #2096 tests: don't use os_release and repo from snapcraft | snapcraft | merged | Merged PR removing os_release and repo imports from the snapcraft module in integration tests, replacing them with dedicated modules. Fixes #1982. Approved by two reviewers and merged despite a suggestion to extract shared functionality. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged tests for missing snap scenarios. Approved by two reviewers and integrated into the codebase despite unresolved review comments and reported integration test timeouts. | |
| #4755 tests: fix devel base snap test | snapcraft | merged | Merged a fix for the devel base snap test. The update ensures snapcraft correctly creates and utilizes the devel base. Approved by two reviewers, passed CI checks, and applied with a minimal one-file change. | |
| #5163 tests: clean up fifos | snapcraft | merged | Merged changes clean up cached FIFOs in the .tox directory that previously broke snapcraft snap builds. Approved by three reviewers with passing CI checks. | |
| #2295 tests: use SNAPCRAFT_PACKAGE_TYPE everywhere | snapcraft | merged | Merged PR #2295 to replace SNAPCRAFT_FROM_ environment variables with SNAPCRAFT_PACKAGE_TYPE across all tests, removing unused container tests and streamlining the spread testing transition. Approved with no coverage impact. | |
| #1569 tests: refactor the fake snapd to not hardcode values | snapcraft | merged | Merged PR refactoring fake snapd tests to remove hardcoded values. Approved by two reviewers, CI passed. Six files changed with 238 additions and 126 deletions. Requires PR #1567. | |
| #1542 tests: add integration tests for build snaps | snapcraft | merged | Merged integration tests for build snaps. Approved by two reviewers and passed CI. Two test scenarios omitted due to known bugs. | |
| #2421 tests: remove obsolete snap and external tests | snapcraft | merged | Merged after maintainer approval, removing obsolete snap and external tests. Accepted despite minor coverage drop and unrelated CI failures, though later noted to break documentation. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines). |