tests: fork skip into snaps_tests
Metadata
Current evaluation
PR #1652 (merged as commit c951a3679) forked a skipped test into snaps_tests to avoid overly broad snapcraft.tests imports that broke autopackage tests.
Resolution: closed resolved
Reason: The PR was merged into the repository as commit c951a3679, titled 'tests: fork skip into snaps_tests (#1652)'. It refactored the test layout to fix the autopackage test breakage caused by broad snapcraft.tests imports.
Evaluated by: mr-cal-bot
No scores available.
Issue body
This is to avoid the overly broad imports done in
snapcraft.tests which break autopackage tests.
Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | PR #1652 (merged as commit c951a3679) forked a skipped test into snaps_tests to avoid overly broad snapcraft.tests imports that broke autopackage tests. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged #1652 (c951a3679), splitting the skipped test into snaps_tests to avoid broad snapcraft.tests imports that broke autopackage tests. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged changes that forked skip into snaps_tests to prevent overly broad imports in snapcraft.tests from breaking autopackage tests. Approved by two reviewers, passed CI, and modified three files. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Merged changes that fork the skip logic into snaps_tests to prevent overly broad imports in snapcraft.tests from breaking autopackage tests. The pull request passed static and unit checks and was successfully integrated. |
Update history
No update history recorded yet.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. | |
| #2716 tests: completely mock subversion tests | snapcraft | merged | Merged PR #2716 (commit 518083bb2) fully mocked the Subversion plugin unit tests in snapcraft, cutting their runtime while keeping integration tests for real behaviour. | |
| #2352 tests: use valid snap names in unit tests | snapcraft | merged | Merged PR #2352 (commit b8c0a4fbf) changed snap names used in unit tests so they pass snap pack --check-skeleton; author merged directly as a minor test-only change. | |
| #46 tests: add fake snapd fixture | craft-parts | merged | Merged PR #46 as 64fdf574 (feature commit 9db65074), adding a 212-line fake snapd fixture for testing snap package handling in craft-parts.packages. | |
| #2295 tests: use SNAPCRAFT_PACKAGE_TYPE everywhere | snapcraft | merged | PR #2295 merged as commit ffbad69ea: unit tests now use SNAPCRAFT_PACKAGE_TYPE instead of legacy SNAPCRAFT_FROM_* env vars, and unused container tests were removed to ease migration to spread. (LP: #1794379) | |
| #1716 tests: split the integration autopkgtests | snapcraft | merged | Merged in snapcraft#1716 via 57af155a7, splitting integration autopkgtests into separate runs to prevent timeout failures despite added setup overhead. | |
| #1068 tests: use a temporary directory for snaps tests | snapcraft | merged | Merged PR #1068 made snaps tests use a temporary directory, fixing Launchpad bug #1643658; landed as commit 1d4e5878d. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged PR #3609 in commit a71aeff54, moving snapcraft_legacy unit tests from tests/unit to tests/legacy to match the package rename. | |
| #2351 tests: use valid snap names in unit tests | snapcraft | closed | Closed unmerged; the same test-only change was merged instead via PR #2352 (commit b8c0a4fbf), updating unit-test snap names to pass `snap pack --check-skeleton`. | |
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Closed unmerged after conflicts; the test reorganization was redone and merged via snapcraft#1948 at commit 55ad11ccc, moving tests out of the snapcraft package. |