← Back to issue list

tests: move test files out of the snapcraft dir

View original Github issue

Metadata

Project
snapcraft
Number
#1948
Type
pull request
State
merged
Author
come-maiz
Labels
Created
Updated
Closed

Current evaluation

Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions.

Suggested action:

No scores available.

Issue body

- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)? - [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)? - [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)? - [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)? - [x] Have you successfully run `./runtests.sh static`? - [x] Have you successfully run `./runtests.sh unit`? -----

Evaluation history

Date Model Scores Action Summary
qwen/qwen3.6-35b-a3b Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions.
qwen3.6-35b-a3b-mtp-q6 Relocated test files from the snapcraft directory to improve project structure. The changes passed static and unit tests and were merged without additional comments or revisions.
qwen3.6-35b-a3b-mtp-q6 Merged changes that relocate test files outside the snapcraft directory. The update passed static and unit tests, successfully reorganizing the repository structure.

Update history

No update history recorded yet.

Related issues

Issue Project State Summary Similarity
#1877 tests: move test files out of the snapcraft dir snapcraft closed Approved and passing local tests, the changes to move test files out of the snapcraft directory were abandoned after a merge conflict arose. The maintainer closed the request to retry the file relocation later.
85%
#1394 tests: document the test suites in the snapcraft repo snapcraft merged Test suite documentation added to snapcraft. Approved by two reviewers, the merge updated two files with 160 additions and 33 deletions to clarify test execution. Reviewer feedback was incorporated prior to merging.
82%
#3609 tests: move legacy snapcraft tests (CRAFT-728) snapcraft merged Merged following reviewer approval and passing CI. Relocated unit tests for the renamed snapcraft_legacy package to tests/legacy, modifying 313 files (+579/-564 lines).
81%
#85 test: cleanup test now that we have a new enough snapcraft snapcraft-rocks merged Merged test cleanup after upgrading to a stable snapcraft version. Removes six lines of outdated test code. Approved by one reviewer, passed all CI checks, and successfully merged.
78%
#2353 tests: remove dependency on snapcraft for integration tests snapcraft merged Merged after reviewer approval and passing CI. The change removes the snapcraft dependency from integration tests to improve test independence, modifying 27 files with 956 additions and 733 deletions.
78%
#50 test: test the snapcraft actions craft-actions merged Merged adding tests for snapcraft actions, mirroring charmcraft tests. Approved by two reviewers with all CI checks passing. Updates two files with 89 additions and 1 deletion.
77%
#137 Added a test to check that the snapcraft files are ignored. snapcraft merged Merged a test verifying snapcraft files are excluded from the build directory, alongside minor base plugin test cleanup. Approved by @kyrofa. Changes span one file with +31/-13 lines.
75%
#3331 spread tests: move package-repositories test snaps into own dir snapcraft merged Merged following reviewer approval and passing CI. Relocated package-repositories test snaps to a dedicated directory to improve test organization and navigation. Modified 7 files.
74%
#386 tests: update testing to use craft-test fetch-service merged Merged. Replaced direct spread calls with snapcraft test in workflows and spread.yaml, requiring a core24 base update. Approved by two reviewers and modified 10 files (+56/-125 lines).
74%
#73 tests: add stage snaps integration test (CRAFT-68) craft-parts merged Merged an integration test verifying stage-snaps are correctly unpacked into the part install directory. Approved by two reviewers, passed CI, and added 133 lines across two files.
74%