tests: move test files out of the snapcraft dir
Metadata
Current evaluation
Merged as commit 55ad11ccc: a pure test-suite reorganization (788 files, +615/-589) moving test files out of the snapcraft/ package dir into top-level tests/; approved by a maintainer and now reflected in the current tests/unit layout.
Resolution: closed resolved
Reason: The PR itself was merged into the repository as commit 55ad11ccc ("tests: move test files out of the snapcraft dir (#1948)"), with review status approved. Current sources confirm the outcome, e.g. pyproject.toml and .gitignore reference tests/unit/... paths rather than files inside the package.
Evaluated by: mr-cal-bot
No scores available.
Issue body
- [x] Have you followed the [guidelines for contributing](https://github.com/snapcore/snapcraft/blob/master/CONTRIBUTING.md)?
- [x] Have you signed the [CLA](http://www.ubuntu.com/legal/contributors/)?
- [x] If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on [bug reports](https://bugs.launchpad.net/snapcraft)?
- [x] If this is a new feature. Have you discussed the design on the [forum](https://forum.snapcraft.io)?
- [x] Have you successfully run `./runtests.sh static`?
- [x] Have you successfully run `./runtests.sh unit`?
-----
Evaluation history
| Date | Model | Scores | Action | Summary |
|---|---|---|---|---|
| stealth/space-bunny-alpha | — | closed resolved | Merged as commit 55ad11ccc: a pure test-suite reorganization (788 files, +615/-589) moving test files out of the snapcraft/ package dir into top-level tests/; approved by a maintainer and now reflected in the current tests/unit layout. | |
| stealth/space-bunny-alpha | — | closed resolved | PR #1948 by maintainer come-maiz was merged as commit 55ad11ccc, relocating test files out of the snapcraft/ package dir into a top-level tests/ tree (tests/unit, tests/integration, tests/spread) — a pure test-layout reorganization. | |
| stealth/space-bunny-alpha | — | closed resolved | Merged in canonical/snapcraft#1948 (55ad11ccc), moving test files out of the snapcraft directory to reorganize the test suite. | |
| qwen/qwen3.6-35b-a3b | — | — | Merged reorganization of the test suite, moving test files out of the snapcraft directory. Approved by one reviewer, the change touched 788 files with 615 additions and 589 deletions. | |
| qwen3.6-35b-a3b-mtp-q6 | — | — | Relocated test files from the snapcraft directory to improve project structure. The changes passed static and unit tests and were merged without additional comments or revisions. |
Update history
No update history recorded yet.
Related work
-
Related To:
canonical/snapcraft#1015
(confidence 72%)
Earlier merged reorganization of command unit tests into a subdirectory, part of the same ongoing test-suite restructuring effort.
Related issues
| Issue | Project | State | Summary | Similarity |
|---|---|---|---|---|
| #1877 tests: move test files out of the snapcraft dir | snapcraft | closed | Closed unmerged after conflicts; the test reorganization was redone and merged via snapcraft#1948 at commit 55ad11ccc, moving tests out of the snapcraft package. | |
| #3609 tests: move legacy snapcraft tests (CRAFT-728) | snapcraft | merged | Merged PR #3609 in commit a71aeff54, moving snapcraft_legacy unit tests from tests/unit to tests/legacy to match the package rename. | |
| #2353 tests: remove dependency on snapcraft for integration tests | snapcraft | merged | PR #2353 by sergiusens merged as commit 6a7c860c4, dropping snapcraft imports from integration tests (27 files, +956/-733) so the suite no longer depends on snapcraft and tests stay independent, alongside the bases/multipass cleanup. | |
| #1394 tests: document the test suites in the snapcraft repo | snapcraft | merged | Merged PR #1394 in commit ddf06b948, documenting Snapcraft's test suites across two files for contributors. | |
| #1849 tests: add snap not found tests | snapcraft | merged | Merged missing-snap test coverage; snapcraft PR #1849 landed as commit 54cf2bd9e. | |
| #458 test: improve test coverage | fetch-service | merged | Merged as commit 47b7773, adding 370 lines of tests across five files; unit tests, linters, Snap builds/tests, and security scans all passed. | |
| #85 test: cleanup test now that we have a new enough snapcraft | snapcraft-rocks | merged | Merged in snapcraft-rocks#85, removing six obsolete test lines after upgrading past the stable Snapcraft behavior delivered by canonical/snapcraft#4666. | |
| #1651903 Plugin tests need to be reorganized | snapcraft (launchpad) | closed | Fixed: plugin unit tests moved out of the monolithic tests dir into a dedicated subdirectory by merged PR snapcore/snapcraft#1014 (commit d97c00e8f), resolving LP bug #1651903. | |
| #2421 tests: remove obsolete snap and external tests | snapcraft | merged | Merged PR #2421 in commit 707395546, deleting 77 obsolete snap/external-test files and 2,959 lines despite a negligible coverage decrease. | |
| #1015 tests: reorganize command tests into subdirectory. | snapcraft | merged | Merged PR #1015 as commit 90b63c94, moving command unit tests into a tests/unit/commands/ subdirectory (30 files, +70/-49) to shrink the unit suite and close LP #1651908. |